Skip to content

Fix mutable default and remove debug statement #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thoth2357 wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −2
Open

Fix mutable default and remove debug statement #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd296e
⚰️ Removed debug print statement
thoth2357 Jan 16, 2026
21f6c55
Fix mutable default argument for meta parameter, thereby preventing t…
thoth2357 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion scrapfly/extraction_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ def __init__(
ephemeral_template: Optional[Dict] = None
):
if template:
print("WARNGING")
warnings.warn(
"Deprecation warning: 'template' is deprecated. Use 'extraction_template' instead."
)
Expand Down
5 changes: 4 additions & 1 deletion scrapfly/scrapy/request.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@ class ScrapflyScrapyRequest(Request):
# headers:Dict inherited
# encoding:Dict inherited

def __init__(self, scrape_config: ScrapeConfig, meta: Dict = {}, *args, **kwargs):
def __init__(self, scrape_config: ScrapeConfig, meta: Optional[Dict] = None, *args, **kwargs):
self.scrape_config = scrape_config

if meta is None:
meta = {}

meta['scrapfly_scrape_config'] = self.scrape_config

super().__init__(
Expand Down