Fix mutable default and remove debug statement #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he common Python pitfall where a mutable default argument is shared across function calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
meta: Dict = {}tometa: Optional[Dict] = NoneinScrapFlyScrapyRequest.__init__if meta is None: meta = {}to handle the None caseWhy
Default mutable arguments in python are evaluated once at function definition, not each time the function is called. So every ScrapFlyScrapyRequest instance that doesnt pass meta explicitly would end up sharing the same dict object.
This can cause weird state leakage issues between requests. Found this while looking thru the code and figured it's worth fixing before it causes problems down the line.