Skip to content

[NOT for REVIEW] Check #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jprakash-db wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[NOT for REVIEW] Check #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfcc81c
Check
jprakash-db Jan 20, 2026
a467a0b
Fixed failling tests
jprakash-db Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/code-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ jobs:
path: .venv
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}
#----------------------------------------------
# install system dependencies for kerberos
#----------------------------------------------
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev
#----------------------------------------------
# install dependencies if cache does not exist
#----------------------------------------------
- name: Install dependencies
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/code-quality-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ jobs:
path: .venv
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ matrix.dependency-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}
#----------------------------------------------
# install system dependencies for kerberos
#----------------------------------------------
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev
#----------------------------------------------
# install dependencies if cache does not exist
#----------------------------------------------
- name: Install dependencies
Expand Down Expand Up @@ -132,6 +137,11 @@ jobs:
path: .venv-pyarrow
key: venv-pyarrow-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ matrix.dependency-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}
#----------------------------------------------
# install system dependencies for kerberos
#----------------------------------------------
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev
#----------------------------------------------
# install dependencies if cache does not exist
#----------------------------------------------
- name: Install dependencies
Expand Down Expand Up @@ -205,6 +215,11 @@ jobs:
path: .venv
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}
#----------------------------------------------
# install system dependencies for kerberos
#----------------------------------------------
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev
#----------------------------------------------
# install dependencies if cache does not exist
#----------------------------------------------
- name: Install dependencies
Expand Down Expand Up @@ -257,6 +272,11 @@ jobs:
path: .venv
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}
#----------------------------------------------
# install system dependencies for kerberos
#----------------------------------------------
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev
#----------------------------------------------
# install dependencies if cache does not exist
#----------------------------------------------
- name: Install dependencies
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/daily-telemetry-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,11 @@ jobs:
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}

#----------------------------------------------
# install system dependencies for kerberos
#----------------------------------------------
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev
#----------------------------------------------
# install dependencies if cache does not exist
#----------------------------------------------
- name: Install dependencies
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ jobs:
path: .venv
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}
#----------------------------------------------
# install system dependencies for kerberos
#----------------------------------------------
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev
#----------------------------------------------
# install dependencies if cache does not exist
#----------------------------------------------
- name: Install dependencies
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/publish-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ jobs:
path: .venv
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}
#----------------------------------------------
# install system dependencies for kerberos
#----------------------------------------------
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev
#----------------------------------------------
# install dependencies if cache does not exist
#----------------------------------------------
- name: Install dependencies
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ jobs:
path: .venv
key: venv-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-${{ github.event.repository.name }}-${{ hashFiles('**/poetry.lock') }}
#----------------------------------------------
# install system dependencies for kerberos
#----------------------------------------------
- name: Install system dependencies
run: sudo apt-get update && sudo apt-get install -y libkrb5-dev
#----------------------------------------------
# install dependencies if cache does not exist
#----------------------------------------------
- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion src/databricks/sql/backend/thrift_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"_retry_delay_default": (float, 5, 1, 60),
}


# Checks
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment "Checks" is too vague and doesn't provide meaningful context. Comments should explain what is being checked or why this section exists. Consider either removing this comment if it's not needed, or making it more descriptive, such as describing the purpose of the ThriftDatabricksClient class that follows.

Suggested change
# Checks
# Thrift-based Databricks SQL client implementation

Copilot uses AI. Check for mistakes.
class ThriftDatabricksClient(DatabricksClient):
CLOSED_OP_STATE = CommandState.CLOSED
ERROR_OP_STATE = CommandState.FAILED
Expand Down
Loading