-
Notifications
You must be signed in to change notification settings - Fork 132
[NOT for REVIEW] Check #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a single comment line (# Checks) before the ThriftDatabricksClient class definition in the thrift backend module. The PR metadata lacks a description of what this change accomplishes or why it was made.
Changes:
- Added a comment
# Checksabove theThriftDatabricksClientclass
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
|
|
||
| # Checks |
Copilot
AI
Jan 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment "Checks" is too vague and doesn't provide meaningful context. Comments should explain what is being checked or why this section exists. Consider either removing this comment if it's not needed, or making it more descriptive, such as describing the purpose of the ThriftDatabricksClient class that follows.
| # Checks | |
| # Thrift-based Databricks SQL client implementation |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
What type of PR is this?
Description
How is this tested?
Related Tickets & Documents