Auction orchestration #147
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ChristianPavilonis
force-pushed
the
feature/auction-integrations
branch
from
92c19a7 to
39cb7dc
Compare
ChristianPavilonis
force-pushed
the
feature/auction-integrations
branch
from
39cb7dc to
c82ffd3
Compare
aram356
left a comment
aram356
left a comment
There was a problem hiding this comment.
👍 Good start
- Please address tests and formatting
- I would like to re-review
ChristianPavilonis
force-pushed
the
feature/auction-integrations
branch
from
d694498 to
eaee2cf
Compare
| let mut responses = Vec::new(); | ||
|
|
||
| for (provider_name, pending, start_time, provider) in pending_requests { | ||
| match pending.wait() { |
There was a problem hiding this comment.
🔧 We have to wait for each response sequentially but i think we should use select to wait for the first ready response so that we can do work while others still execute
see: https://docs.rs/fastly/latest/fastly/http/request/fn.select.html
| // Phase 1: Launch all requests concurrently | ||
| let mut pending_requests = Vec::new(); | ||
|
|
||
| for provider_name in provider_names { |
There was a problem hiding this comment.
🔧 We should have timeout for each provider
| price: None, // Encoded price in metadata, decoded by mediation | ||
| currency: "USD".to_string(), | ||
| creative: None, | ||
| adomain: Some(vec!["amazon.com".to_string()]), |
There was a problem hiding this comment.
❓ Why is amazon.com hard coded
There was a problem hiding this comment.
I set it to None for now. Looking into it I think my aps request structure isn't accurate to what I see in the browser.
| ); | ||
|
|
||
| // Create a modified request with all bids attached | ||
| let mut mediation_request = request.clone(); |
There was a problem hiding this comment.
♻️ Reconsider cloning with Cow<'_, AuctionRequest>
There was a problem hiding this comment.
Cow wouldn't help because we need to mutate.
What do you think of these changes? 0b7811
| @@ -0,0 +1,906 @@ | |||
| //! Amazon Publisher Services (APS/TAM) integration. | |||
There was a problem hiding this comment.
❓ We decide not mock here. Is there reason why it is still here?
There was a problem hiding this comment.
This module for now is sending "aps" bid requests to the configured mock server, to test orchestrator and simulate how aps bids flow to an ad server, but perhaps it shouldn't be called aps.
ChristianPavilonis
force-pushed
the
feature/auction-integrations
branch
from
8e518c7 to
c6dee36
Compare
Closes #139