Add bidder params and debug helpers to openrtb request #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aram356
requested changes
Jan 15, 2026
| })); | ||
| } | ||
|
|
||
| // Parse bids from query parameter if present |
Collaborator
There was a problem hiding this comment.
🤔 I know this is draft but can we finally move to specific structs.
ChristianPavilonis
force-pushed
the
feature/kargo-integration
branch
2 times, most recently
from
fbae661 to
1f11d06
Compare
ChristianPavilonis
changed the base branch from
main
to
fix/proxy-compression-issues
ChristianPavilonis
force-pushed
the
feature/kargo-integration
branch
2 times, most recently
from
1543ff3 to
dac30b3
Compare
ChristianPavilonis
force-pushed
the
feature/kargo-integration
branch
from
dac30b3 to
d199f21
Compare
ChristianPavilonis
force-pushed
the
fix/proxy-compression-issues
branch
from
9de521a to
d0b99c1
Compare
aram356
requested changes
Jan 22, 2026
Collaborator
aram356
left a comment
aram356
left a comment
There was a problem hiding this comment.
There is some opportunity to improve it.
| let mut page_url = format!("https://{}", settings.publisher.domain); | ||
|
|
||
| // Append debug query params if configured | ||
| if let Some(ref params) = config.debug_query_params { |
Collaborator
There was a problem hiding this comment.
⛏️ similar on 827 and 280
extract to a function
fn append_query_params(url: &str, params: &str) -> String {
if params.is_empty() || url.contains(params) {
return url.to_string();
}
if url.contains('?') {
format!("{}&{}", url, params)
} else {
format!("{}?{}", url, params)
}
}
| } | ||
|
|
||
| // Add debug flag if enabled | ||
| if self.config.debug { |
Collaborator
There was a problem hiding this comment.
🔧 Please use concrete types
| } | ||
| } | ||
|
|
||
| log::info!("Prebid OpenRTB request: {:#?}", openrtb_json); |
Collaborator
There was a problem hiding this comment.
❓ Should we be logging the whole request? At least change to debug
| } | ||
|
|
||
| let body_bytes = response.take_body_bytes(); | ||
| log::info!("Prebid OpenRTB response: {}", String::from_utf8_lossy(&body_bytes)); |
Collaborator
There was a problem hiding this comment.
❓ Should we log the whole response? At least change to debug
| bidder.insert(bidder_name.clone(), Json::Object(serde_json::Map::new())); | ||
| } | ||
| // Use bidder params from the slot (passed through from the request) | ||
| let bidder: std::collections::HashMap<String, Json> = slot |
Collaborator
There was a problem hiding this comment.
❓ What happens if there no bidders. Should we the settings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting until #147 is merged.