-
Notifications
You must be signed in to change notification settings - Fork 115
Add column alignment support for tables #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/enhance-table-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+298
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Create Column interface with ALIGN_LEFT, ALIGN_RIGHT, ALIGN_CENTER constants - Update Renderer base class to support alignments and headers - Update Ascii renderer to apply alignment when padding columns - Update Table class to support alignment in constructor and setAlignments() - Add comprehensive tests for all alignment types - Address PR #171 feedback: headers passed explicitly to renderer, validation allows setting alignments before headers Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
- Extract getColumnAlignment() method for better readability - Use array_flip() for O(1) lookups instead of in_array() O(n) searches - Address code review feedback Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enhance table format to right-align numeric values
Add column alignment support for tables
Jan 20, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
swissspidy
reviewed
Jan 20, 2026
Use a static property to cache the valid alignments map, avoiding the overhead of array creation and array_flip() on every setAlignments() call. Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table Column Alignment Feature
This PR implements table column alignment functionality to address wp-cli/db-command#239, which requests the ability to right-align numeric values in tables for better readability.
Visual Comparison
BEFORE: Database Table Sizes (Left-Aligned - Hard to Compare)
AFTER: Database Table Sizes (Right-Aligned - Easy to Compare!)
Notice how the numeric values now line up vertically, making it much easier to compare sizes at a glance!
Usage
Implementation Details
New Files:
lib/cli/table/Column.php- Interface defining alignment constantsexamples/table-alignment.php- Comprehensive usage examplesModified Files:
lib/cli/table/Renderer.php- Base class support for alignments and headerslib/cli/table/Ascii.php- Applies alignment when padding columnslib/cli/Table.php- Table class with alignment supporttests/Test_Table.php- Comprehensive test coverageAlignment Constants:
Column::ALIGN_LEFT(default) - Left-align textColumn::ALIGN_RIGHT- Right-align (perfect for numbers)Column::ALIGN_CENTER- Center-align textPR #171 Feedback Addressed
This implementation addresses all feedback from PR #171:
✅ Headers passed explicitly to renderer (#171 comment)
setHeaders()method instead of being inferred from the first row✅ Validation allows setting alignments before headers (#171 comment)
✅ Code quality improvements
getColumnAlignment()method for better readabilityarray_flip()for O(1) lookupsBackward Compatibility
Testing
Use Cases
This feature enables:
Example Output
See
examples/table-alignment.phpfor a complete demonstration with multiple real-world examples.Closes wp-cli/db-command#239
Based on PR #171 by @rolf-yoast
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.