Skip to content

Table::getDisplayLines() should not output excessive lines when no rows #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slaFFik wants to merge 6 commits into from
+9 −7
Closed

Table::getDisplayLines() should not output excessive lines when no rows #165

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d4b774
Table::getDisplayLines() should not output excessive lines
slaFFik Sep 28, 2023
f492746
fix testDrawWithHeadersNoData()
slaFFik Sep 29, 2023
2a1e318
Merge branch 'master' into patch-2
swissspidy Nov 2, 2025
21cc164
Merge branch 'main' into patch-2
swissspidy Jan 20, 2026
e075e84
Merge branch 'main' into patch-2
swissspidy Jan 20, 2026
5967246
Fix merge hiccup
swissspidy Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions lib/cli/Table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,16 +164,16 @@ public function display() {
public function displayRow(array $row) {
// Update widths if this row has wider content
$row = $this->checkRow($row);

// Recalculate widths for the renderer
$this->_renderer->setWidths($this->_width, false);

$rendered_row = $this->_renderer->row($row);
$row_lines = explode( PHP_EOL, $rendered_row );
foreach ( $row_lines as $line ) {
Streams::line( $line );
}

$border = $this->_renderer->border();
if (isset($border)) {
Streams::line( $border );
Expand Down Expand Up @@ -203,10 +203,12 @@ public function getDisplayLines() {
$out[] = $border;
}

foreach ($this->_rows as $row) {
$row = $this->_renderer->row($row);
$row = explode( PHP_EOL, $row );
$out = array_merge( $out, $row );
if ($this->_rows) {
foreach ($this->_rows as $row) {
$row = $this->_renderer->row($row);
$row = explode( PHP_EOL, $row );
$out = array_merge( $out, $row );
}
}

// Only add final border if there are rows
Expand Down