-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
stdbuf: support libstdbuf in same directory as stdbuf #10352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Unfortunately, Cygwin (windows) does not allow symlink by default. Would you disable tests on Cygwin? |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
Which test is failing on Cygwin? test_stdbuf_search_order_exe_dir_first ? |
|
Cygwin package does not run test currently, but CI would not allow all of tests creating symlink. |
The test I am adding does not create a symlink, so it is not clear to me what you are asking me to do. |
Does it means tester should manually create a symlink? |
The build system creates a symlink, and would print a warning on cygwin if the command to create the symlink fails. |
Thats fine for me! |
694448a to
5f7aac1
Compare
Make stdbuf search for libstdbuf first in the directory where stdbuf is running. This matches GNU coreutils behavior. Add a symlink to deps/libstdbuf in order to make it easier to run the stdbuf tests with feat_external_stdbuf enabled. Remove tests which are assuming that libstdbuf is not found. Those tests are now always failing, because the build directory contains a symlink to deps/libstdbuf and libstdbuf is always found. Fixes uutils#10345 Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
5f7aac1 to
7bd4c53
Compare
|
GNU testsuite comparison: |
Make stdbuf search for libstdbuf first in the directory where stdbuf is running. This matches GNU coreutils behavior. Add a symlink to deps/libstdbuf in order to make it easier to run the stdbuf tests with feat_external_stdbuf enabled.
Remove tests which are assuming that libstdbuf is not found. Those tests are now always failing, because the build directory contains a symlink to deps/libstdbuf and libstdbuf is always found.
Fixes #10345