Add tests for policies on UUIDv7 hypertables #9138
Open
+259
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_chunk_to_recompress function passes the boundary value from get_window_boundary to ts_time_value_to_internal with the original partitioning type. However, for UUID-partitioned tables, get_window_boundary returns a TIMESTAMPTZ datum (not UUID), so we need to use TIMESTAMPTZOID for the conversion. Fix this by converting the boundary_type to TIMESTAMPTZOID when the partitioning type is UUID, matching the approach used for retention policies.
Add a test for compression policy on UUID-partitioned hypertables. The test verifies that compression policy with INTERVAL correctly compresses chunks older than the specified threshold.
Add a test for reorder policy on UUID-partitioned hypertables. The reorder policy works without any changes since it doesn't use time-based parameters - it only requires an index name.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9138 +/- ##
==========================================
+ Coverage 82.42% 82.54% +0.11%
==========================================
Files 244 244
Lines 47953 47930 -23
Branches 12235 12232 -3
==========================================
+ Hits 39525 39563 +38
- Misses 3553 3554 +1
+ Partials 4875 4813 -62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@antekresic, @natalya-aksman: please review this pull request.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for compression and reorder policies on UUIDv7 hypertables. Also fix an issue discovered for compression policies. Below is the description for the fix commit:
Fix compression policy on UUID hypertables
The get_chunk_to_recompress function passes the boundary value from get_window_boundary to ts_time_value_to_internal with the original partitioning type. However, for UUID-partitioned tables, get_window_boundary returns a TIMESTAMPTZ datum (not UUID), so we need to use TIMESTAMPTZOID for the conversion.
Fix this by converting the boundary_type to TIMESTAMPTZOID when the partitioning type is UUID, matching the approach used for retention policies.
Disable-check: commit-count
Disable-check: force-changelog-file