Add datatype checks for compressed datatype to dictionary code #9063
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akuzm, @kpan2034: please review this pull request.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9063 +/- ##
==========================================
+ Coverage 82.40% 82.49% +0.09%
==========================================
Files 242 242
Lines 47617 47594 -23
Branches 12154 12153 -1
==========================================
+ Hits 39238 39262 +24
- Misses 3509 3519 +10
+ Partials 4870 4813 -57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svenklemm
added
the
tech-debt
akuzm
approved these changes
Jan 14, 2026
akuzm
reviewed
Jan 14, 2026
| (void *) PG_DETOAST_DATUM(dictionary_compressed), | ||
| true, | ||
| element_type); | ||
| CheckCompressedData(element_type == iterator->compressed->element_type); |
Member
There was a problem hiding this comment.
this one should probably be an assertion, since the data itself is checked by the "init" function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.