Enable BSM on unordered compressed chunks #9042
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
added
the
enhancement
|
@melihmutlu, @fabriziomello: please review this pull request.
|
antekresic
force-pushed
the
add_bsm_to_unordered
branch
from
a3f4792 to
5ae99e1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9042 +/- ##
==========================================
+ Coverage 82.45% 82.55% +0.10%
==========================================
Files 243 243
Lines 47938 47912 -26
Branches 12234 12230 -4
==========================================
+ Hits 39525 39554 +29
- Misses 3544 3545 +1
+ Partials 4869 4813 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akuzm
reviewed
Dec 15, 2025
antekresic
force-pushed
the
add_bsm_to_unordered
branch
from
5ae99e1 to
9a73f73
Compare
antekresic
force-pushed
the
add_bsm_to_unordered
branch
from
9a73f73 to
7c1de66
Compare
antekresic
force-pushed
the
add_bsm_to_unordered
branch
from
7c1de66 to
8fa2e7d
Compare
svenklemm
approved these changes
Jan 14, 2026
antekresic
force-pushed
the
add_bsm_to_unordered
branch
from
8fa2e7d to
0640307
Compare
Unordered compressed chunks can benefit from batch sorted merge optimization just like ordered chunks can because we sort the batches and merge them during execution time giving us the same results regardless if the batches are overlapping.
akuzm
approved these changes
Jan 14, 2026
Member
akuzm
left a comment
akuzm
left a comment
There was a problem hiding this comment.
So basically we're enabling batch sorted merge on unordered chunks because it doesn't care about this order, only about the per-batch order. Let's explain this a little in the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unordered compressed chunks can benefit from batch sorted merge optimization just like ordered chunks can because we sort the batches and merge them during execution time giving us the same results regardless if the batches are overlapping.