Skip to content

Conversation

@seanlaw
Copy link
Contributor

@seanlaw seanlaw commented Jan 23, 2026

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

  • Fork, clone, and checkout the newest version of the code
  • Create a new branch
  • Make necessary code changes
  • Install black (i.e., python -m pip install black or conda install -c conda-forge black)
  • Install flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
  • Install pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
  • Run black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./ in the root stumpy directory
  • Run flake8 --extend-exclude=.venv ./ in the root stumpy directory
  • Run ./setup.sh dev && ./test.sh in the root stumpy directory
  • Reference a Github issue (and create one if one doesn't already exist)

@gitnotebooks
Copy link

gitnotebooks bot commented Jan 23, 2026

Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1120

@seanlaw
Copy link
Contributor Author

seanlaw commented Jan 23, 2026

@NimaSarajpoor I believe that this solves the issue (all tests are passing). Please review at your earliest convenience

Copy link
Collaborator

@NimaSarajpoor NimaSarajpoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Just added one more comment (regarding the description of the param copy). Thanks for the fix!

@NimaSarajpoor NimaSarajpoor merged commit ce05903 into stumpy-dev:main Jan 23, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants