-
Notifications
You must be signed in to change notification settings - Fork 339
Fixed #1116 Avoid Import Fastmath Functions #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1117 |
|
@NimaSarajpoor This is ready to be reviewed at your earliest convenience, thanks! |
NimaSarajpoor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanlaw
Looks good to me. Nice fix!
|
It's really strange that all tests were passing before the commit. However, after the code was committed, some of the tests are failing but nothing has changed. |
And the error says: I cannot understand why it shows "read-only". Update: Apparently the error appears when input time series is of type |
I was able to reproduce this with pandas And this gives: Update: For the above example,
|
See #1116
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory