[FIX] models - gemini - start and stop reasoningContent #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/strands/experimental/hooks/multiagent/events.py # src/strands/multiagent/graph.py # src/strands/multiagent/swarm.py # src/strands/session/session_manager.py # tests/fixtures/mock_multiagent_hook_provider.py # tests/strands/hooks/test_events.py # tests/strands/hooks/test_multi_agent_hooks.py # tests/strands/multiagent/conftest.py # tests/strands/multiagent/test_graph.py # tests/strands/multiagent/test_swarm.py # tests_integ/hooks/multiagent/test_cancel.py # tests_integ/hooks/multiagent/test_events.py # tests_integ/interrupts/multiagent/test_hook.py
JackYPCOnline
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Gemini models with thinking_config enabled, the reasoning/thinking content was being printed to console but not captured in the agent's message history.
This PR:
Modified the Gemini model provider to properly capture reasoning content by implementing content type switching:
Referenced fix:
https://github.com/strands-agents/sdk-python/pull/947/files#diff-a1ec2ea9af3dcd76184638c766807d737d33e9c308d229c075423e961a00174c
Related Issues
#1394
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.