Skip to content

Conversation

@dbschmigelski
Copy link
Member

Description

CodeQL flagged a missing permissions block on the validate job in the Lambda layer publish workflow.
Without explicit permissions, the job inherits the default repository GITHUB_TOKEN permissions, which
violates the principle of least privilege.

The validate job only runs a bash string comparison to confirm user intent—it doesn't interact with
GitHub APIs or access repository contents. Explicitly setting empty permissions ensures this job has no
unnecessary access, consistent with how other workflows in this repository are configured.

Resolves: https://github.com/strands-agents/sdk-python/security/code-scanning/8

Related Issues

#636

Documentation PR

N/A

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • [] I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dbschmigelski dbschmigelski enabled auto-merge (squash) January 23, 2026 20:47
@dbschmigelski dbschmigelski merged commit 1cedaed into strands-agents:main Jan 23, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants