Skip to content

Conversation

@ovalenti
Copy link
Contributor

@ovalenti ovalenti commented Jan 23, 2026

Description

There are numerous CI failures with a message stating that the container could not be started because of an invalid internal state of the container runtime.

We try to wait for the new container to be ready (not-running) before starting it.

The /wait API endpoint may return an error when the race condition occurs, we add a log statement to determine this.

The new API call could also just delay things, making the race condition less frequent.

2026/01/23 07:32:41 INFO: start external-connection with quay.io/rhacs-eng/qa-multi-arch:alpine-curl-2.0.5 (dcd32a1451f7)
    base.go:74: 
        	Error Trace:	/home/runner/work/collector/collector/integration-tests/suites/base.go:74
        	            				/home/runner/work/collector/collector/integration-tests/suites/runtime_config_file.go:115
        	            				/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.9.0/suite/suite.go:192
        	Error:      	Received unexpected error:
        	            	Error response from daemon: runc: runc create failed: unable to start container process: error during container init: error setting cgroup config for procHooks process: unable to freeze: OCI runtime error
        	            	start collector
        	            	github.com/stackrox/collector/integration-tests/pkg/executor.(*dockerAPIExecutor).StartContainer
        	            		/home/runner/work/collector/collector/integration-tests/pkg/executor/executor_docker_api.go:159
        	            	github.com/stackrox/collector/integration-tests/pkg/collector.(*DockerCollectorManager).launchCollector
        	            		/home/runner/work/collector/collector/integration-tests/pkg/collector/collector_docker.go:149
        	            	github.com/stackrox/collector/integration-tests/pkg/collector.(*DockerCollectorManager).Launch
        	            		/home/runner/work/collector/collector/integration-tests/pkg/collector/collector_docker.go:81
        	            	github.com/stackrox/collector/integration-tests/suites.(*IntegrationTestSuiteBase).StartCollector
        	            		/home/runner/work/collector/collector/integration-tests/suites/base.go:74
        	            	github.com/stackrox/collector/integration-tests/suites.(*RuntimeConfigFileTestSuite).SetupTest
        	            		/home/runner/work/collector/collector/integration-tests/suites/runtime_config_file.go:115
        	            	github.com/stretchr/testify/suite.Run.func1
        	            		/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.9.0/suite/suite.go:192
        	            	testing.tRunner
        	            		/home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.6.linux-amd64/src/testing/testing.go:1690
        	            	runtime.goexit
        	            		/home/runner/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.23.6.linux-amd64/src/runtime/asm_amd64.s:1700
        	Test:       	TestRuntimeConfigFile/TestRuntimeConfigFileDisable

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

@ovalenti ovalenti self-assigned this Jan 23, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.38%. Comparing base (3f3e16d) to head (57b8136).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2818   +/-   ##
=======================================
  Coverage   27.38%   27.38%           
=======================================
  Files          95       95           
  Lines        5427     5427           
  Branches     2548     2548           
=======================================
  Hits         1486     1486           
  Misses       3214     3214           
  Partials      727      727           
Flag Coverage Δ
collector-unit-tests 27.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovalenti ovalenti marked this pull request as ready for review January 23, 2026 12:45
@ovalenti ovalenti requested a review from a team as a code owner January 23, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants