feat(dom): DOM - toBeEmpty #162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbsCruz
commented
Jan 16, 2026
| }; | ||
| } | ||
|
|
||
| export function isElementEmpty (element: Element): boolean { |
Contributor
Author
There was a problem hiding this comment.
Just a little comment about this function team, this is a helper indeed, but since we have a lot of helpers for the styles matchers in this file, should we rename it to something like helpers/style.ts? causing the isElementEmpty function to be moved to another file? or are we ok with what we have now, thanks!
Collaborator
There was a problem hiding this comment.
I think that is a good approach to take into account! As helpers.ts is becoming a bit of a mixed bag. So we can have this file renamed to style-helpers.ts to keep the CSS logic isolated, and the isElementEmpty to a new dom-helpers.ts file. That should keep the separation of concerns clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the toBeEmpty matcher.