Skip to content

Add a Jackson 3 converter #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sschuberth wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Add a Jackson 3 converter #4552

sschuberth wants to merge 2 commits into from
+617 −0

Conversation

@sschuberth
Copy link

@sschuberth sschuberth commented Nov 5, 2025 •
edited
Loading

  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

@JakeWharton
Copy link
Collaborator

JakeWharton commented Nov 6, 2025

Thanks! This mostly looks good from a quick check.

I want to familiarize myself with this major release, but otherwise I hope to get this merged this month and released by EOY.

@sschuberth
Copy link
Author

sschuberth commented Nov 6, 2025

I ran ./gradlew spotlessApply to address the linter issues and squashed the formatting fixes into the last commit.

@sschuberth
Copy link
Author

sschuberth commented Nov 18, 2025

Mind approving the workflow once more to verify that tests now pass, @JakeWharton?

@sschuberth
Add jackson-annotations as an explicit test dependency
b60214c 
This was implicitly available as a transitive dependency, but that
should not be relied on.

It is required for `JsonAutoDetect.Visibility.ANY`.

Note that `jackson-annotations` is versioned independently of the rest
of Jackson and does not use a path-level version suffix.
@sschuberth
Add a converter for Jackson 3
9f78f8c 
This mostly copies the existing Jackson (2) converter and does the
necessary migration [1]. Note that Jackson 3 requires Java 17.

[1]: https://github.com/FasterXML/jackson/blob/main/jackson3/MIGRATING_TO_JACKSON_3.md
@sschuberth
Copy link
Author

sschuberth commented Dec 15, 2025

Mind approving the workflow once more to verify that tests now pass, @JakeWharton?

I've rebased this to catch-up with the new required final-status check, but now running checks needs an approval again.

@sschuberth sschuberth mentioned this pull request Dec 15, 2025
Draft
@sschuberth
Copy link
Author

sschuberth commented Dec 22, 2025

I hope to get this merged this month and released by EOY.

Is there still a chance to get this merged before the end of the year?

@sschuberth
Copy link
Author

sschuberth commented Jan 8, 2026

I hope to get this merged this month and released by EOY.

Is there still a chance to get this merged before the end of the year?

Happy new year ping 😉

@JakeWharton
Copy link
Collaborator

JakeWharton commented Jan 8, 2026

I have quit this company a few months ago so any work I do here is entirely volunteer work. I appreciate the contribution, but it'll still probably be a few weeks until I look at this project again.

@patschl
Copy link

patschl commented Jan 16, 2026

Hi! I'm also quite interested in this PR being merged. Is @JakeWharton the only maintainer of this project?

@JakeWharton
Copy link
Collaborator

JakeWharton commented Jan 17, 2026

The design of Retrofit is such that you do not need this to be merged to be unblocked. You can have your own Jackson 3 converter living in your codebase for the time being.

And yes, it's basically just me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sschuberth @JakeWharton @patschl