Skip to content

Fix SPIFFE ID scheme detection #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rturner3 merged 1 commit into from
Jan 22, 2026
+3 −2
Merged

Fix SPIFFE ID scheme detection #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java-spiffe-core/src/main/java/io/spiffe/spiffeid/SpiffeId.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public static SpiffeId parse(final String id) {
throw new IllegalArgumentException(EMPTY);
}

if (!id.contains(SCHEME_PREFIX)) {
if (!id.startsWith(SCHEME_PREFIX)) {
throw new InvalidSpiffeIdException(WRONG_SCHEME);
}

Expand Down
3 changes: 2 additions & 1 deletion java-spiffe-core/src/test/java/io/spiffe/spiffeid/SpiffeIdTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ static Stream<Arguments> provideInvalidSpiffeIds() {
Arguments.of("spiffe://trustdomain/./other", "Path cannot contain dot segments"),
Arguments.of("spiffe://trustdomain/../other", "Path cannot contain dot segments"),
Arguments.of("spiffe://trustdomain/", "Path cannot have a trailing slash"),
Arguments.of("spiffe://trustdomain/path/", "Path cannot have a trailing slash")
Arguments.of("spiffe://trustdomain/path/", "Path cannot have a trailing slash"),
Arguments.of("xspiffe://trustdomain/path", "Scheme is missing or invalid")
);
}

Expand Down