-
Notifications
You must be signed in to change notification settings - Fork 40
Fix: Repeated Warning Message "Preparation count cannot be negative" #7595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… text of html 5 validation to avoid both of them running
Triggered by b636151 on branch refs/heads/issue-7156
Triggered by 7f72143 on branch refs/heads/issue-7156
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- verify that inputting a negative CountAMT field in Preparations results in a error and that you cannot save ( this should use the specify Save Blockers and display message "Preparation count cannot be negative")
- Verify that only a single message error message appears( this time the HTML 5 message should appear only and display message "Please Select a value no less than 0")
- (optional) Test in at least one more preparation view/subview
Looks good, message only appears once.
01-08_08.40.mp4
grantfitzsimmons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- verify that inputting a negative CountAMT field in Preparations results in a error and that you cannot save ( this should use the specify Save Blockers and display message "Preparation count cannot be negative")
- Verify that only a single message error message appears( this time the HTML 5 message should appear only and display message "Please Select a value no less than 0")
- (optional) Test in at least one more preparation view/subview
👌
kwhuber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- verify that inputting a negative CountAMT field in Preparations results in a error and that you cannot save ( this should use the specify Save Blockers and display message "Preparation count cannot be negative")
- Verify that only a single message error message appears( this time the HTML 5 message should appear only and display message "Please Select a value no less than 0")
- (optional) Test in at least one more preparation view/subview
Nice job!
Fixes #7156
Prevented an issue Cause by both html5 min validation and Specify's negative validation both being triggered at the same time, causing the error popup to display multiple cannot be negative messages to be added to the popup
Note: this error appears after the countAMT field has the
initialize="min=0"field set in its form definition, see instructions below to recreate or follow testing instruction from #6462.Screen.Recording.2025-12-18.at.12.19.27.PM.mov
Checklist
self-explanatory (or properly documented)
Testing instructions
initialize="min=0"to the<cell type="field" id="3" name="countAmt" uitype="text"/>if neededLike this: