Skip to content

Conversation

@emir-karabeg
Copy link
Collaborator

Summary

Added email broadcast.

Fixed logs details.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

Solo.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 20, 2026 7:48pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Summary

This PR adds a new email broadcast template for the v0.5 release announcement and fixes the deployment version badge in log details to use the EMCN Badge component instead of hardcoded styles.

Key changes:

  • Replaced hardcoded badge styling with Badge component in log details (apps/sim/app/workspace/[workspaceId]/logs/components/log-details/log-details.tsx:260-262)
  • Added new broadcast email template with 4 major features: Copilot, MCP Deployment, Logs & Dashboard, and Realtime Collaboration
  • Included 3 image assets (copilot.gif, dashboard.jpeg, logo.svg) for the email

Issues found:

  • Missing mcp.png image asset referenced in the email template at line 94

Confidence Score: 3/5

  • This PR is mostly safe but has one critical missing asset that will break the email
  • The log details bug fix is clean and follows component library patterns correctly. However, the email template references a missing mcp.png image that will cause broken images in production emails.
  • Pay close attention to apps/sim/emails/broadcasts/v0.5.html - missing MCP image asset must be added

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/logs/components/log-details/log-details.tsx Replaced hardcoded badge styling with Badge component from EMCN library for deployment version display
apps/sim/emails/broadcasts/v0.5.html New email broadcast template for v0.5 release announcement with 4 features, missing MCP image asset

Sequence Diagram

sequenceDiagram
    participant User
    participant LogDetailsUI
    participant BadgeComponent
    participant EmailTemplate
    participant Assets

    Note over User,Assets: Bug Fix: Log Details Badge
    User->>LogDetailsUI: View log details
    LogDetailsUI->>BadgeComponent: Render deployment version
    BadgeComponent-->>LogDetailsUI: Display Badge(variant='green', size='md')
    LogDetailsUI-->>User: Show styled version badge

    Note over User,Assets: New Feature: Email Broadcast v0.5
    User->>EmailTemplate: Receive email broadcast
    EmailTemplate->>Assets: Load logo.svg
    Assets-->>EmailTemplate: ✓ Logo loaded
    EmailTemplate->>Assets: Load copilot.gif
    Assets-->>EmailTemplate: ✓ Copilot GIF loaded
    EmailTemplate->>Assets: Load dashboard.jpeg
    Assets-->>EmailTemplate: ✓ Dashboard image loaded
    EmailTemplate->>Assets: Load mcp.png
    Assets-->>EmailTemplate: ✗ Missing image
    EmailTemplate-->>User: Render email (with broken MCP image)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

<table cellspacing="0" cellpadding="0" border="0" role="presentation">
<tr>
<td align="center" style="padding-bottom:16px;">
<img src="https://sim.ai/email/broadcast/v0.5/mcp.png" width="48" height="48" alt="MCP" style="display:block;" border="0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: missing mcp.png image at /apps/sim/public/email/broadcast/v0.5/mcp.png - this will break the email template

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/emails/broadcasts/v0.5.html
Line: 94:94

Comment:
**logic:** missing `mcp.png` image at `/apps/sim/public/email/broadcast/v0.5/mcp.png` - this will break the email template

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants