Skip to content

fix(kb): align bulk chunk operation with API response #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Jan 20, 2026
Merged

fix(kb): align bulk chunk operation with API response #2899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c31aa8c
fix(kb): align bulk chunk operation with API response
waleedlatif1 Jan 20, 2026
7479225
fix(kb): skip local state update for failed chunks
waleedlatif1 Jan 20, 2026
fece740
fix(kb): correct errors type and refresh on partial failure
waleedlatif1 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,15 +538,11 @@ export function Document({
},
{
onSuccess: (result) => {
if (operation === 'delete') {
if (operation === 'delete' || result.errorCount > 0) {
refreshChunks()
} else {
result.results.forEach((opResult) => {
if (opResult.operation === operation) {
opResult.chunkIds.forEach((chunkId: string) => {
updateChunk(chunkId, { enabled: operation === 'enable' })
})
}
chunks.forEach((chunk) => {
updateChunk(chunk.id, { enabled: operation === 'enable' })
})
}
logger.info(`Successfully ${operation}d ${result.successCount} chunks`)
Expand Down
9 changes: 4 additions & 5 deletions apps/sim/hooks/queries/knowledge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,12 +755,11 @@ export interface BulkChunkOperationParams {
}

export interface BulkChunkOperationResult {
operation: string
successCount: number
failedCount: number
results: Array<{
operation: string
chunkIds: string[]
}>
errorCount: number
processed: number
errors: string[]
}

export async function bulkChunkOperation({
Expand Down