CW-2776_Issue_with_casserver_and_service_urls_with_module.php_in_path #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin tests accordingly
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.0 #65 +/- ##
=================================================
+ Coverage 68.03% 68.05% +0.02%
Complexity 364 364
=================================================
Files 25 25
Lines 1220 1221 +1
=================================================
+ Hits 830 831 +1
Misses 390 390 🚀 New features to boost your workflow:
|
tvdijen
reviewed
Jan 26, 2026
| // Construct the ReturnTo URL | ||
| return $this->httpUtils->getSelfURLNoQuery() . '?' . http_build_query($query); | ||
| $returnToBase = Module::getModuleURL('casserver/login'); | ||
| return $returnToBase . '?' . http_build_query($query); |
Member
There was a problem hiding this comment.
This should be giving the exact same result?
If this is not the case, I think it might be better to rely on Symfony's request object and use $request->getBaseUrl() instead of our own http-utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.