Skip to content

Conversation

@jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Jan 20, 2026

This fixes https://jira.sil.org/browse/LT-22353. We want to add merge rules (2 -> 1) and split rules (1 -> 2) in the phonology. It turns out that NarrowAnalysisRewriteRuleSpec implemented merge rules, but the code had never been tested and there was a bug when the right hand side had anything in it. I added unit tests and fixed the bug. It also turned out that NarrowAnalysisRewriteRuleSpec worked for expanding as well as narrowing, so I added unit tests for expanding and code to use NarrowAnalysisRewriteRuleSpec in this case. There is no need to test for an infinite loop (see EpenthesisSynthesisRewriteSubruleSpec) when expanding since a rule cannot apply to its own output.


This change is Reviewable

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3).

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.67%. Comparing base (58392e4) to head (35e728c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   72.61%   72.67%   +0.06%     
==========================================
  Files         423      423              
  Lines       35992    36009      +17     
  Branches     4965     4965              
==========================================
+ Hits        26134    26169      +35     
+ Misses       8760     8745      -15     
+ Partials     1098     1095       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtmaxwell3 jtmaxwell3 merged commit f458988 into master Jan 20, 2026
4 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22353 branch January 20, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants