Removed duplicate NetFx48* definitions #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were necessary for Wix 3.11, since it didn't include those, but with Wix 3.14, these two ID's already exist. This is necessary for the build servers, which are using v3.14
Author
|
Related to sillsdev/wesay#104 |
Author
|
@jasonleenaylor, is this something we'd like merged into master? |
Collaborator
|
Sorry about leaving this here for so long, the FlexBridge and FieldWorks installers aren't actually running on Wix 3.14, there is a 3.14.1 bug that makes their builds fail in GHA so it's been rolled back to 3.11, WeSay builds successfully on 3.14 so this is a good change for that, but because this is used for other installers I can't merge it in yet. The right move is probably to redo this repository to use Wix 4. I'm leaving this PR just in case we can get FlexBridge and FieldWorks to build with 3.14 on gha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were necessary for Wix 3.11, since it didn't include those, but with Wix 3.14, these two ID's already exist. This is necessary for the build servers, which are using v3.14
This change is