LT-20393: Import user styles w/o clearing the stylesheet first #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paragraph element is required for all paragraph styles, even if it is empty (LT-20393). Also add `fwdictconfig` to the solution spelling dictionary.
During Dictionary View import, existing styles were being cleared before importing new styles, so if the new styles could not be imported, the stylesheet would be left empty. To fix this, import styles without clearing the stylesheet first. This also simplifies the import process, which was likely complicated to compensate for incomplete exports pre-9.3.5. * Export <paragraph> elements for paragraph styles, even if empty (should be the case for only Normal, as all other paragraph styles should have at least a basedOn attribute). * Export 'structure' and 'use' attributes for each Style. * If 'structure' and 'use' attributes are missing on a known style, use the pre-import values. * Catch more exceptions during style import. * Unit test style import POSSIBLE FUTURE WORK: * Rewrite the style import to handle importing shared user styles differently from loading new installed styles * Check for style importability in DictConfigImportCtlr.PrepareImport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is