-
Notifications
You must be signed in to change notification settings - Fork 4
feat: [PR-1483] show expanded zone availability #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed Files
|
7c82456 to
5aa2554
Compare
Greptile SummaryThis PR redesigns the Key changes:
The command text updates in Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CLI as sf zones ls
participant API as /v0/zones API
participant Display as ZonesTableDisplay
User->>CLI: Execute command
CLI->>CLI: Check if user is logged in
alt Not logged in
CLI->>User: Show login message
else Logged in
CLI->>API: GET /v0/zones
API-->>CLI: Return zone data with available_capacity
alt JSON output requested
CLI->>User: Output JSON
else Table output
CLI->>CLI: Filter zones by availability
loop For each zone
CLI->>CLI: Calculate capacity metrics<br/>(now, 1 day, 1 week)
end
alt No zones with availability
CLI->>Display: Render EmptyZonesDisplay
Display->>User: Show "no zones available" message
else Zones available
CLI->>CLI: Sort zones by availability
CLI->>Display: Render ZonesTableDisplay
Display->>User: Show table with availability columns
end
end
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
src/lib/zones.tsx, line 16 (link)syntax:
componentstype is not imported.Add the import at the top of the file:
import { components } from "../schema.ts";
1 file reviewed, 4 comments
|
@greptile review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
Redesign
sf zones lsto be more info dense + show soonest/max node count