Skip to content

♻️ Replace assertions with explicit exceptions #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiWeiss merged 1 commit into from
Jan 14, 2026
Merged

♻️ Replace assertions with explicit exceptions #505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions bibtexparser/library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,22 @@ def replace(self, old_block: Block, new_block: Block, fail_on_duplicate_key: boo
def _cast_to_duplicate(
prev_block_with_same_key: Union[Entry, String], duplicate: Union[Entry, String]
):
assert isinstance(prev_block_with_same_key, type(duplicate)) or isinstance(
duplicate, type(prev_block_with_same_key)
), (
"Internal BibtexParser Error. Duplicate blocks share no common type."
f"Found {type(prev_block_with_same_key)} and {type(duplicate)}, but both should be"
f"either instance of String or instance of Entry."
f"Please report this issue at the bibtexparser issue tracker.",
)

assert (
prev_block_with_same_key.key == duplicate.key
), "Internal BibtexParser Error. Duplicate blocks have different keys."
if not (
isinstance(prev_block_with_same_key, type(duplicate))
or isinstance(duplicate, type(prev_block_with_same_key))
):
raise ValueError(
"Internal BibtexParser Error. Duplicate blocks share no common type. "
f"Found {type(prev_block_with_same_key)} and {type(duplicate)}, but both should be "
"either instance of String or instance of Entry. "
"Please report this issue at the bibtexparser issue tracker."
)

if prev_block_with_same_key.key != duplicate.key:
raise ValueError(
"Internal BibtexParser Error. Duplicate blocks have different keys. "
"Please report this issue at the bibtexparser issue tracker."
)

return DuplicateBlockKeyBlock(
start_line=duplicate.start_line,
Expand Down
Loading