docs/tests: fix rustdoc links and appease clippy strict lints

Cargo.toml

@@ -4,10 +4,7 @@ name = "ndarray"
 version = "0.17.2"
 edition = "2021"
 rust-version = "1.64"
-authors = [
-  "Ulrik Sverdrup \"bluss\"",
-  "Jim Turner"
-]
+authors = ["Ulrik Sverdrup \"bluss\"", "Jim Turner"]
 license = "MIT OR Apache-2.0"
 readme = "README-crates.io.md"
 
@@ -20,12 +17,12 @@ keywords = ["array", "data-structure", "multidimensional", "matrix", "blas"]
 categories = ["data-structures", "science"]
 
 include = [
-    "/src/**/*.rs",
-    "LICENSE-MIT",
-    "LICENSE-APACHE",
-    "RELEASES.md",
-    "README.rst",
-    "README-quick-start.md"
+  "/src/**/*.rs",
+  "LICENSE-MIT",
+  "LICENSE-APACHE",
+  "RELEASES.md",
+  "README.rst",
+  "README-quick-start.md",
 ]
 resolver = "2"
 
@@ -46,9 +43,13 @@ rayon = { version = "1.10.0", optional = true }
 cblas-sys = { workspace = true, optional = true }
 libc = { version = "0.2.82", optional = true }
 
-matrixmultiply = { version = "0.3.2", default-features = false, features=["cgemm"] }
+matrixmultiply = { version = "0.3.2", default-features = false, features = [
+  "cgemm",
+] }
 
-serde = { version = "1.0", optional = true, default-features = false, features = ["alloc"] }
+serde = { version = "1.0", optional = true, default-features = false, features = [
+  "alloc",
+] }
 rawpointer = { version = "0.2" }
 
 [dev-dependencies]
@@ -77,20 +78,17 @@ portable-atomic-critical-section = ["portable-atomic/critical-section"]
 
 [target.'cfg(not(target_has_atomic = "ptr"))'.dependencies]
 portable-atomic = { version = "1.6.0" }
-portable-atomic-util = { version = "0.2.0", features = [ "alloc" ] }
+portable-atomic-util = { version = "0.2.0", features = ["alloc"] }
 
 [workspace]
-members = [
-    "ndarray-rand",
-    "crates/*",
-]
+members = ["ndarray-rand", "crates/*"]
 default-members = [
-    ".",
-    "ndarray-rand",
-    "crates/ndarray-gen",
-    "crates/numeric-tests",
-    "crates/serialization-tests",
-    # exclude blas-tests and blas-mock-tests that activate "blas" feature
+  ".",
+  "ndarray-rand",
+  "crates/ndarray-gen",
+  "crates/numeric-tests",
+  "crates/serialization-tests",
+  # exclude blas-tests and blas-mock-tests that activate "blas" feature
 ]
 
 [workspace.dependencies]
@@ -105,7 +103,9 @@ approx = { version = "0.5", default-features = false }
 quickcheck = { version = "1.0", default-features = false }
 rand = { version = "0.9.0", features = ["small_rng"] }
 rand_distr = { version = "0.5.0" }
-itertools = { version = "0.13.0", default-features = false, features = ["use_std"] }
+itertools = { version = "0.13.0", default-features = false, features = [
+  "use_std",
+] }
 cblas-sys = { version = "0.1.4", default-features = false }
 
 [profile.bench]

crates/blas-tests/Cargo.toml

@@ -39,4 +39,3 @@ accelerate = ["blas-src", "blas-src/accelerate"]
 # Config for cargo-release
 [package.metadata.release]
 release = false
-

crates/ndarray-gen/Cargo.toml

@@ -11,4 +11,3 @@ num-traits = { workspace = true }
 # Config for cargo-release
 [package.metadata.release]
 release = false
-

crates/numeric-tests/Cargo.toml

@@ -18,8 +18,13 @@ approx = { workspace = true }
 rand = { workspace = true }
 rand_distr = { workspace = true }
 
-blas-src = { optional = true, version = "0.10", default-features = false, features = ["openblas"] }
-openblas-src = { optional = true, version = ">=0.10.11", default-features = false, features = ["cblas", "system"] }
+blas-src = { optional = true, version = "0.10", default-features = false, features = [
+  "openblas",
+] }
+openblas-src = { optional = true, version = ">=0.10.11", default-features = false, features = [
+  "cblas",
+  "system",
+] }
 
 [dev-dependencies]
 num-traits = { workspace = true }

examples/sort-axis.rs

@@ -20,14 +20,10 @@ pub struct Permutation
 impl Permutation
 {
     /// Checks if the permutation is correct
-    pub fn from_indices(v: Vec<usize>) -> Result<Self, ()>
+    pub fn from_indices(v: Vec<usize>) -> Option<Self>
     {
         let perm = Permutation { indices: v };
-        if perm.correct() {
-            Ok(perm)
-        } else {
-            Err(())
-        }
+        perm.correct().then_some(perm)
     }
 
     fn correct(&self) -> bool

ndarray-rand/Cargo.toml

@@ -14,11 +14,11 @@ description = "Constructors for randomized arrays. `rand` integration for `ndarr
 keywords = ["multidimensional", "matrix", "rand", "ndarray"]
 
 include = [
-    "/src/**/*.rs",
-    "LICENSE-MIT",
-    "LICENSE-APACHE",
-    "RELEASES.md",
-    "README.rst"
+  "/src/**/*.rs",
+  "LICENSE-MIT",
+  "LICENSE-APACHE",
+  "RELEASES.md",
+  "README.rst",
 ]
 
 [dependencies]
@@ -34,4 +34,3 @@ quickcheck = { workspace = true }
 
 [package.metadata.release]
 tag-name = "ndarray-rand-{{version}}"
-

rustfmt.toml

@@ -5,7 +5,7 @@ fn_call_width = 100
 max_width = 120
 brace_style = "AlwaysNextLine"
 control_brace_style = "AlwaysSameLine"
-fn_params_layout = "Compressed" # ?
+fn_params_layout = "Compressed"          # ?
 format_macro_bodies = false
 imports_granularity = "Preserve"
 imports_indent = "Block"
@@ -16,7 +16,7 @@ match_arm_blocks = false
 match_arm_leading_pipes = "Preserve"
 merge_derives = false
 overflow_delimited_expr = true
-reorder_modules = false  # impacts rustdoc order
+reorder_modules = false                  # impacts rustdoc order
 short_array_element_width_threshold = 32
 skip_macro_invocations = ["*"]
 unstable_features = true

src/doc/crate_feature_flags.rs

@@ -14,9 +14,14 @@
 //! ## `serde`
 //!   - Enables serialization support for serde 1.x
 //!
-//! ## `rayon`
-//!   - Enables parallel iterators, parallelized methods, the [`parallel`] module and [`par_azip!`].
-//!   - Implies std
+#![cfg_attr(
+    not(feature = "rayon"),
+    doc = "//! ## `rayon`\n//!   - Enables parallel iterators, parallelized methods, and the `par_azip!` macro.\n//!   - Implies std\n"
+)]
+#![cfg_attr(
+    feature = "rayon",
+    doc = "//! ## `rayon`\n//!   - Enables parallel iterators, parallelized methods, the [`crate::parallel`] module and [`crate::parallel::par_azip`].\n//!   - Implies std\n"
+)]
 //!
 //! ## `approx`
 //!   - Enables implementations of traits of the [`approx`] crate.
@@ -28,8 +33,3 @@
 //!
 //! ## `matrixmultiply-threading`
 //!   - Enable the ``threading`` feature in the matrixmultiply package
-//!
-//! [`parallel`]: crate::parallel
-
-#[cfg(doc)]
-use crate::parallel::par_azip;

src/lib.rs

@@ -84,11 +84,18 @@
 //! ## Crate Feature Flags
 //!
 //! The following crate feature flags are available. They are configured in your
-//! `Cargo.toml`. See [`doc::crate_feature_flags`] for more information.
+//! `Cargo.toml`. See [`crate::doc::crate_feature_flags`] for more information.
 //!
 //! - `std`: Rust standard library-using functionality (enabled by default)
 //! - `serde`: serialization support for serde 1.x
-//! - `rayon`: Parallel iterators, parallelized methods, the [`parallel`] module and [`par_azip!`].
+#![cfg_attr(
+    not(feature = "rayon"),
+    doc = "//! - `rayon`: Parallel iterators, parallelized methods, and the `par_azip!` macro."
+)]
+#![cfg_attr(
+    feature = "rayon",
+    doc = "//! - `rayon`: Parallel iterators, parallelized methods, the [`parallel`] module and [`par_azip!`]."
+)]
 //! - `approx` Implementations of traits from the [`approx`] crate.
 //! - `blas`: transparent BLAS support for matrix multiplication, needs configuration.
 //! - `matrixmultiply-threading`: Use threading from `matrixmultiply`.
@@ -129,7 +136,7 @@ extern crate std;
 #[cfg(feature = "blas")]
 extern crate cblas_sys;
 
-#[cfg(docsrs)]
+#[cfg(any(doc, docsrs))]
 pub mod doc;
 
 use alloc::fmt::Debug;

src/linalg/impl_linalg.rs

@@ -968,6 +968,63 @@ where
     is_blas_2d(a._dim(), a._strides(), BlasOrder::F)
 }
 
+/// Dot product for dynamic-dimensional arrays (`ArrayD`).
+///
+/// For one-dimensional arrays, computes the vector dot product, which is the sum
+/// of the elementwise products (no conjugation of complex operands).
+/// Both arrays must have the same length.
+///
+/// For two-dimensional arrays, performs matrix multiplication. The array shapes
+/// must be compatible in the following ways:
+/// - If `self` is *M* × *N*, then `rhs` must be *N* × *K* for matrix-matrix multiplication
+/// - If `self` is *M* × *N* and `rhs` is *N*, returns a vector of length *M*
+/// - If `self` is *M* and `rhs` is *M* × *N*, returns a vector of length *N*
+/// - If both arrays are one-dimensional of length *N*, returns a scalar
+///
+/// **Panics** if:
+/// - The arrays have dimensions other than 1 or 2
+/// - The array shapes are incompatible for the operation
+/// - For vector dot product: the vectors have different lengths
+impl<A> Dot<ArrayRef<A, IxDyn>> for ArrayRef<A, IxDyn>
+where A: LinalgScalar
+{
+    type Output = Array<A, IxDyn>;
+
+    fn dot(&self, rhs: &ArrayRef<A, IxDyn>) -> Self::Output
+    {
+        match (self.ndim(), rhs.ndim()) {
+            (1, 1) => {
+                let a = self.view().into_dimensionality::<Ix1>().unwrap();
+                let b = rhs.view().into_dimensionality::<Ix1>().unwrap();
+                let result = a.dot(&b);
+                ArrayD::from_elem(vec![], result)
+            }
+            (2, 2) => {
+                // Matrix-matrix multiplication
+                let a = self.view().into_dimensionality::<Ix2>().unwrap();
+                let b = rhs.view().into_dimensionality::<Ix2>().unwrap();
+                let result = a.dot(&b);
+                result.into_dimensionality::<IxDyn>().unwrap()
+            }
+            (2, 1) => {
+                // Matrix-vector multiplication
+                let a = self.view().into_dimensionality::<Ix2>().unwrap();
+                let b = rhs.view().into_dimensionality::<Ix1>().unwrap();
+                let result = a.dot(&b);
+                result.into_dimensionality::<IxDyn>().unwrap()
+            }
+            (1, 2) => {
+                // Vector-matrix multiplication
+                let a = self.view().into_dimensionality::<Ix1>().unwrap();
+                let b = rhs.view().into_dimensionality::<Ix2>().unwrap();
+                let result = a.dot(&b);
+                result.into_dimensionality::<IxDyn>().unwrap()
+            }
+            _ => panic!("Dot product for ArrayD is only supported for 1D and 2D arrays"),
+        }
+    }
+}
+
 #[cfg(test)]
 #[cfg(feature = "blas")]
 mod blas_tests
@@ -1083,60 +1140,3 @@ mod blas_tests
         }
     }
 }
-
-/// Dot product for dynamic-dimensional arrays (`ArrayD`).
-///
-/// For one-dimensional arrays, computes the vector dot product, which is the sum
-/// of the elementwise products (no conjugation of complex operands).
-/// Both arrays must have the same length.
-///
-/// For two-dimensional arrays, performs matrix multiplication. The array shapes
-/// must be compatible in the following ways:
-/// - If `self` is *M* × *N*, then `rhs` must be *N* × *K* for matrix-matrix multiplication
-/// - If `self` is *M* × *N* and `rhs` is *N*, returns a vector of length *M*
-/// - If `self` is *M* and `rhs` is *M* × *N*, returns a vector of length *N*
-/// - If both arrays are one-dimensional of length *N*, returns a scalar
-///
-/// **Panics** if:
-/// - The arrays have dimensions other than 1 or 2
-/// - The array shapes are incompatible for the operation
-/// - For vector dot product: the vectors have different lengths
-impl<A> Dot<ArrayRef<A, IxDyn>> for ArrayRef<A, IxDyn>
-where A: LinalgScalar
-{
-    type Output = Array<A, IxDyn>;
-
-    fn dot(&self, rhs: &ArrayRef<A, IxDyn>) -> Self::Output
-    {
-        match (self.ndim(), rhs.ndim()) {
-            (1, 1) => {
-                let a = self.view().into_dimensionality::<Ix1>().unwrap();
-                let b = rhs.view().into_dimensionality::<Ix1>().unwrap();
-                let result = a.dot(&b);
-                ArrayD::from_elem(vec![], result)
-            }
-            (2, 2) => {
-                // Matrix-matrix multiplication
-                let a = self.view().into_dimensionality::<Ix2>().unwrap();
-                let b = rhs.view().into_dimensionality::<Ix2>().unwrap();
-                let result = a.dot(&b);
-                result.into_dimensionality::<IxDyn>().unwrap()
-            }
-            (2, 1) => {
-                // Matrix-vector multiplication
-                let a = self.view().into_dimensionality::<Ix2>().unwrap();
-                let b = rhs.view().into_dimensionality::<Ix1>().unwrap();
-                let result = a.dot(&b);
-                result.into_dimensionality::<IxDyn>().unwrap()
-            }
-            (1, 2) => {
-                // Vector-matrix multiplication
-                let a = self.view().into_dimensionality::<Ix1>().unwrap();
-                let b = rhs.view().into_dimensionality::<Ix2>().unwrap();
-                let result = a.dot(&b);
-                result.into_dimensionality::<IxDyn>().unwrap()
-            }
-            _ => panic!("Dot product for ArrayD is only supported for 1D and 2D arrays"),
-        }
-    }
-}

src/partial.rs

@@ -37,6 +37,7 @@ impl<T> Partial<T>
     }
 
     #[cfg(feature = "rayon")]
+    #[allow(dead_code)]
     pub(crate) fn stub() -> Self
     {
         Self {
@@ -46,6 +47,7 @@ impl<T> Partial<T>
     }
 
     #[cfg(feature = "rayon")]
+    #[allow(dead_code)]
     pub(crate) fn is_stub(&self) -> bool
     {
         self.ptr.is_null()
@@ -60,6 +62,7 @@ impl<T> Partial<T>
     }
 
     #[cfg(feature = "rayon")]
+    #[allow(dead_code)]
     /// Merge if they are in order (left to right) and contiguous.
     /// Skips merge if T does not need drop.
     pub(crate) fn try_merge(mut left: Self, right: Self) -> Self

src/zip/mod.rs

@@ -424,6 +424,7 @@ where D: Dimension
     }
 
     #[cfg(feature = "rayon")]
+    #[allow(dead_code)]
     pub(crate) fn uninitialized_for_current_layout<T>(&self) -> Array<MaybeUninit<T>, D>
     {
         let is_f = self.prefer_f();