Skip to content

Improvements to specs of Hash.[] #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eregon merged 2 commits into from
Jan 18, 2026
+9 −9
Merged

Improvements to specs of Hash.[] #1328

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67b74b4
Small improvoments to specs of Hash.[]
herwinw Jan 18, 2026
a3b0974
Include message validation in expected exception of Hash.[]
herwinw Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions core/hash/constructor_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,23 @@

it "raises for elements that are not arrays" do
-> {
Hash[[:a]].should == {}
}.should raise_error(ArgumentError)
Hash[[:a]]
}.should raise_error(ArgumentError, "wrong element type Symbol at 0 (expected array)")
-> {
Hash[[:nil]].should == {}
}.should raise_error(ArgumentError)
Hash[[nil]]
}.should raise_error(ArgumentError, "wrong element type nil at 0 (expected array)")
end

it "raises an ArgumentError for arrays of more than 2 elements" do
->{ Hash[[[:a, :b, :c]]].should == {} }.should raise_error(ArgumentError)
->{
Hash[[[:a, :b, :c]]]
}.should raise_error(ArgumentError, "invalid number of elements (3 for 1..2)")
end

it "raises an ArgumentError when passed a list of value-invalid-pairs in an array" do
-> {
-> {
Hash[[[:a, 1], [:b], 42, [:d, 2], [:e, 2, 3], []]]
}.should complain(/ignoring wrong elements/)
}.should raise_error(ArgumentError)
Hash[[[:a, 1], [:b], 42, [:d, 2], [:e, 2, 3], []]]
}.should raise_error(ArgumentError, "wrong element type Integer at 2 (expected array)")
end

describe "passed a single argument which responds to #to_hash" do
Expand Down