Use sets to optimize ordered Unicode collections #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First of all, thanks for the great work on this project.
I noticed that the construction of
orderedScriptsandorderedBlockscurrently relies on checking membership in lists:This results in an O(N) lookup for each iteration, making the overall process more expensive as the lists grow. The logic is correct and clear, but the membership check itself can be optimized.
To keep the same behavior while improving performance, this PR introduces auxiliary sets:
These sets are used only to track which values were already added, while the lists are still responsible for preserving order.
With this change:
It’s a small and safe change, but it improves efficiency and makes the logic a bit more explicit.