chore(ios): remove old architecture code #4130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove React Native old architecture (Paper/Bridge) code from iOS, keeping only new architecture (Fabric/TurboModules) code. Changes: - Delete all *ViewManager.m and *ViewManager.swift files (old arch view managers) - Remove #ifdef RCT_NEW_ARCH_ENABLED guards from ComponentView files - Simplify Module.h files to only conform to TurboModule protocols - Remove old arch conditionals from Module.mm files - Update RNMBXViewResolver to remove old arch code paths - Remove unused RCTViewManager imports from Bridge/RNMBX.h and Swift.pre.h - Remove guards from RNMBXFabricPropConvert.mm and RNMBXFollyConvert.h This is a follow-up to the Android old architecture removal (#4128) and continues the 10.3.0 cleanup work (#4118).
The umbrella header is compiled as Objective-C (not Objective-C++), which causes errors when ComponentView.h files import Fabric headers that transitively include C++ code like <atomic>. Use #ifdef __cplusplus guard instead of RCT_NEW_ARCH_ENABLED to: - Allow content when compiled as Objective-C++ (.mm files) - Hide content when compiled as Objective-C (umbrella header)
Move 16 module methods from static RNMBXMapViewManager methods to instance methods on RNMBXMapView, fixing build errors after old architecture removal.
Move Foundation/UIKit imports outside __cplusplus guard and provide plain NSObject interface for non-C++ contexts (Swift).
…ource Call methods directly on view instances instead of through Manager classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove React Native old architecture (Paper/Bridge) code from iOS, keeping only new architecture (Fabric/TurboModules) code.
Changes:
This is a follow-up to the Android old architecture removal (#4128) and continues the 10.3.0 cleanup work (#4118).
Description
Fixes #
Added
your featurethat allows ...Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reproduce the issue you're fixing