[Php81] Exclude Doctrine ODM MongoDB 2.16 Document and EmbeddedDocument from ReadOnlyPropertyRector. #7848
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you rebase latest main branch? We currently pin to phpstan 2.1.34 on main branch as phpstan 2.1.35 cause issue. We don't have ODM set on doctrine, feel free to create rule/upgrade config there and register to config set https://github.com/rectorphp/rector-doctrine/tree/main/config/sets Thank you. |
…nt from ReadOnlyPropertyRector.
mickverm
force-pushed
the
readonlypropertyrector-doctrine-mongodb-odm-2.16
branch
from
16085f0 to
64fff92
Compare
Contributor
Author
|
I've rebased it. I'll see what I can do once I have some spare time. |
samsonasik
approved these changes
Jan 21, 2026
TomasVotruba
approved these changes
Jan 21, 2026
Member
|
Looks good, thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace was changed in
doctrine/mongodb-odm 2.16, see: doctrine/mongodb-odm#2933Ref: #6721
Should a rule be added to automatically replace the attribute?