Skip to content

Conversation

@calebdw
Copy link
Contributor

@calebdw calebdw commented Jan 20, 2026

@TomasVotruba, @samsonasik

Important

The problem appears to be in the latest PHPStan 2.1.35 release

@calebdw
Copy link
Contributor Author

calebdw commented Jan 20, 2026

@TomasVotruba, @samsonasik please see driftingly/rector-laravel#466, something in the last release (either in rector or phpstan) is causing both this ci to fail and rector-laravel to fail

I will continue to dig on my end

@calebdw calebdw force-pushed the calebdw/push-pqkkozvwtloq branch 2 times, most recently from c38c47c to 408db5d Compare January 20, 2026 22:01
@calebdw calebdw force-pushed the calebdw/push-pqkkozvwtloq branch 2 times, most recently from 2babcc9 to 819efa6 Compare January 20, 2026 22:06
@calebdw
Copy link
Contributor Author

calebdw commented Jan 20, 2026

@TomasVotruba, @samsonasik the problem seems to be in these last 2 commits:

image

Reverting them (and pinning the phpstan version to 2.1.33) allows the PHP Tests to pass (the other tests are related to the other packages likely pulling in the latest phpstan)

image

@calebdw calebdw force-pushed the calebdw/push-pqkkozvwtloq branch 2 times, most recently from a3c8336 to 5973fa7 Compare January 20, 2026 22:13
@samsonasik
Copy link
Member

@calebdw I will check in separate PR :)

The rector-downgrade-php already phpstan 2.1.35

https://github.com/rectorphp/rector-src/actions/runs/21189253042/job/60951735934?pr=7846#step:6:32

@samsonasik
Copy link
Member

@calebdw I created 2 PRs that show that in PHPStan 2.1.34 (working), and PHPStan 2.1.35 (not working)

@calebdw calebdw closed this Jan 21, 2026
@calebdw calebdw deleted the calebdw/push-pqkkozvwtloq branch January 21, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants