Use pak::local_install_deps() in install()
#2651
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
commented
Jan 22, 2026
| build_opts <- c("--no-resave-data", "--no-manual") | ||
| # Install dependencies | ||
| local({ | ||
| if (quiet) { |
Member
Author
There was a problem hiding this comment.
Hack around lack of quiet argument or option for pak.
| if (build) { | ||
| install_path <- pkgbuild::build( | ||
| pkg$path, | ||
| build = build, |
Member
Author
There was a problem hiding this comment.
It's a bit hard to see in the diff, but we're no longer passing any build or install options when we install the dependencies. I think this is likely to be fine, since you'd generally except these to coming from CRAN and not built locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some general updates to the docs of
install(), and mild improvements to non-quiet output.Fixes #2486. Fixes #2572.
@jennybc if you're testing
install()interactively, it doesn't work on devtools itself, for probably obvious reasons.