Audio: Increase pre-merge test coverage to 10 test cases #243

tmoida · 2026-01-02T13:47:03Z

Expanded audio testing from 2 to 10 test cases in the pre-merge CI pipeline to improve validation coverage across different audio formats and configurations.

Changes:

AudioRecord: Added support for 10 recording configurations
AudioPlayback: Added support for 20 playback configurations
meta-ar-ci-premerge.yaml: Updated to run 7 playback + 3 record tests

AudioRecord enhancements:

Implemented config discovery mode with 10 predefined test configurations
Added --config-name and --config-filter CLI options for flexible test selection
Updated documentation with configuration table and usage examples
Modified YAML to support new config parameters (defaults to record_config1)

AudioPlayback enhancements:

Implemented clip discovery mode with 20 predefined test configurations
Added --clip-name and --clip-filter CLI options for flexible test selection
Updated documentation with configuration table and usage examples
Modified YAML to support new clip parameters (defaults to Config1)

Pre-merge CI updates:

7 playback tests: Config1, Config7, Config13, Config15, Config18, Config20, Config5
3 record tests: record_config1, record_config7, record_config10
Uses pre-staged clips at /home/AudioClips/ for faster execution
10-second recording duration for efficient CI runtime

Test coverage now includes:

Sample rates: 8KHz to 384KHz
Bit depths: 8-bit to 32-bit
Channel configs: Mono, Stereo, 5.1, 7.1 surround

smuppand · 2026-01-07T10:13:32Z

Runner/utils/audio_common.sh

+# Discover all audio clip files in the clips directory
+# Returns: space-separated list of clip filenames (basenames only)
+# Exit codes: 0=success, 1=directory not found or no clips
+discover_audio_clips() {


Your header says it returns space-separated basenames, but it actually prints one basename per line.
That’s not inherently wrong, but many callers then do:

available_clips="$(discover_audio_clips 2>&1)" for clip in $available_clips; do ...

either update comment (“newline-separated list”), or output a single line.

smuppand · 2026-01-07T10:15:47Z

Runner/utils/audio_common.sh

+  clip_filter="$2"
+
+  # Discover all available clips
+  available_clips="$(discover_audio_clips 2>&1)" || {


Either change discover_audio_clips to only print clips on stdout and log on stderr. Or don’t use 2>&1 here.

smuppand · 2026-01-07T10:19:37Z

Runner/utils/audio_common.sh

+    # Count total clips first
+    idx=0
+    for clip in $available_clips; do
+      idx=$((idx + 1))


Arithmetic expansion $((...)) is not POSIX for all /bin/sh
Use expr or awk, or better, avoid manual counting and use set -- $available_clips; idx=$# (POSIX).

smuppand · 2026-01-07T10:21:41Z

Runner/utils/audio_common.sh

+  clips_dir="${AUDIO_CLIPS_BASE_DIR:-AudioClips}"
+
+  # If name already looks like a filename, try direct path
+  if printf '%s' "$name" | grep -q '\.wav$'; then


grep -F -q -- "$search_name"
Same issue exists in apply_clip_filter where grep -q "$pattern" treats pattern as regex. If you intend substring matching, use grep -F.

smuppand · 2026-01-07T10:26:19Z

Runner/utils/audio_common.sh

+  # Extract components using sed
+  rate="$(printf '%s' "$filename" | sed -n 's/.*_\([0-9.]\+KHz\)_.*/\1/p')"
+  bits="$(printf '%s' "$filename" | sed -n 's/.*_\([0-9]\+b\)_.*/\1/p')"
+  channels="$(printf '%s' "$filename" | sed -n 's/.*_\([0-9]\+ch\)\.wav$/\1/p')"


Heavy sed for rate, bits and channels. Tighten patterns to match exact 4-field structure from end:
RATE..._BITS_CHANNELS.wav anchored near the end.

smuppand · 2026-01-07T11:09:56Z

Runner/suites/Multimedia/Audio/AudioPlayback/run.sh

+    clip_path="$clips_dir/$clip_file"
+
+    # Validate clip file
+    if ! validate_clip_file "$clip_path"; then


Make Config mapping explicit and stable (Config1 → specific descriptive testcase name / specific filename pattern), not “Nth entry”.
Or define a fixed list inside audio_common.sh for the 20 configs.
Otherwise, Config5 might test a different format on a different system/release, defeating CI intent.

smuppand · 2026-01-07T11:10:53Z

Runner/suites/Multimedia/Audio/AudioPlayback/run.sh

+      if [ "$rc" -eq 0 ]; then
+        log_pass "[$case_name] loop $i OK (rc=0, ${last_elapsed}s)"
+        ok_runs=$((ok_runs + 1))
+      elif [ "$rc" -eq 124 ] && [ "$dur_s" -gt 0 ] 2>/dev/null && [ "$last_elapsed" -ge "$min_ok" ]; then


compute expected duration for the clip or remove timeout-pass heuristic for clip mode. If clips are 30s, you can set dur_s=30 and min_ok to a sane threshold.

smuppand · 2026-01-07T11:12:20Z

Runner/utils/audio_common.sh

+  fi
+
+  # Check not empty
+  size="$(stat -c '%s' "$clip_path" 2>/dev/null || wc -c < "$clip_path" 2>/dev/null)"


stat -c '%s' (GNU stat). Your fallback to wc -c < file helps, but you still call GNU stat first in many places. either use wc -c consistently (simple and portable)
or centralize “file_size_bytes()” helper with robust fallbacks.

smuppand · 2026-01-07T11:15:23Z

Runner/suites/Multimedia/Audio/AudioPlayback/run.sh

-  --formats "wav"
-  --durations "short|short medium|short medium long"
+  --formats "wav"                    # DEPRECATED: Use clip discovery instead
+  --durations "short|short medium"   # DEPRECATED: Use clip discovery instead


Why comment says deprecated when these are being used?

smuppand · 2026-01-07T11:16:56Z

Runner/suites/Multimedia/Audio/AudioPlayback/run.sh

+
+  # Collect evidence once at end (not per clip)
+  if [ "$DMESG_SCAN" -eq 1 ]; then
+    scan_audio_dmesg "$LOGDIR"


scans dmesg once per config(inside config loop). That can be heavy for 10 configs and makes attribution unclear. Scan once at the end of the suite (and optionally on first failure)

tmoida · 2026-01-12T11:08:13Z

PR Response - Review Comments Addressed

Hi @smuppand,

Thanks for the thorough review. I've pushed an updated commit that addresses all the issues you raised.
Here's what changed:

Changes Made

POSIX Compliance & Portability:

Replaced all $((...)) arithmetic with expr for POSIX sh compatibility
Centralized file size checks using wc -c instead of GNU-specific stat -c
Fixed grep patterns to use -F flag for literal string matching

I/O Separation:

Cleaned up stdout/stderr separation across all helper functions
Data output goes to stdout only, logs to stderr
Removed 2>&1 redirections and grep filters from callers

Config Stability:

Implemented stable Config1-Config20 mapping with explicit case statements
Each config now maps to a specific audio format (e.g., Config1 → play_16KHz_16b_2ch)

Code Optimization:

Optimized metadata parsing (single sed call instead of three)
Simplified validation logic (removed redundant pattern checks)

CI/LAVA Support:

Added --res-suffix parameter for unique result files
Updated YAML to generate distinct files: AudioPlayback_Config1.res, AudioRecord_Config7.res, etc.
Prevents result file overwriting in parallel execution

Performance:

Moved dmesg scanning from per-test to end-of-suite (single scan)
Implemented clip-specific timeout handling based on actual duration from filename

Documentation:

Fixed confusing "DEPRECATED" comments (now "Legacy matrix mode only")
Added comprehensive usage examples for both testing modes

Please review the latest changes and let me know if any further modifications are required.

smuppand · 2026-01-13T03:04:42Z

Runner/suites/Multimedia/Audio/AudioRecord/run.sh

+  log_info "Using config discovery mode"
+
+  # Discover and filter configs
+  CONFIGS_TO_TEST="$(discover_and_filter_record_configs "$CONFIG_NAMES" "$CONFIG_FILTER")"


CONFIGS_OUTPUT is undefined, so that branch can’t work as intended. Playback does this correctly, Do the same for record as well.

The current AudioRecord code already uses the correct variable name CONFIGS_TO_TEST and follows the same pattern as AudioPlayback. There is no CONFIGS_OUTPUT variable in the current code.

smuppand · 2026-01-13T03:05:21Z

Runner/suites/Multimedia/Audio/AudioRecord/run.sh

+      log_skip "$TESTNAME SKIP - $ERROR_MSG"
    fi
+    echo "$TESTNAME SKIP" > "$RES_FILE"
+    exit 2


Please use exit 0

Changed all exit 2 to exit 0 for SKIP conditions in AudioRecord/run.sh to match framework standard (PASS=0, FAIL=1, SKIP=0).

smuppand · 2026-01-13T03:07:20Z

Runner/suites/Multimedia/Audio/AudioPlayback/run.sh

+if [ "$USE_CLIP_DISCOVERY" = "auto" ]; then
+  # Auto mode: use clip discovery if AudioClips directory exists, otherwise legacy
+  clips_dir="${AUDIO_CLIPS_BASE_DIR:-AudioClips}"
+  if [ -d "$clips_dir" ] && [ -n "$(find "$clips_dir" -maxdepth 1 -name "*.wav" -type f 2>/dev/null | head -n1)" ]; then


-maxdepth is not posix, Replace with a simpler pattern or tolerate scanning a little deeper.

Replaced find -maxdepth with POSIX-compliant shell glob pattern in AudioPlayback/run.sh.

tmoida · 2026-01-13T12:54:46Z

Hi @smuppand,

The current implementation (AudioRecord) already uses the correct pattern matching AudioPlayback. It uses CONFIGS_TO_TEST (not CONFIGS_OUTPUT) with proper if/else logic and error handling.
Changed all exit 2 to exit 0 for SKIP conditions in AudioRecord/run.sh to match framework standard (PASS=0, FAIL=1, SKIP=0).
Replaced find -maxdepth with POSIX-compliant shell glob pattern in AudioPlayback/run.sh.

Please review the latest changes and let me know if any further modifications are required.

smuppand · 2026-01-13T17:34:41Z

@tmoida Please follow the guidelines. Reply to the corresponding review comment for which your latest changes resolved. It will be easy to review. Otherwise, it is hard to review and go through all files.

smuppand · 2026-01-14T02:55:40Z

Runner/plans/meta-ar-ci-premerge.yaml

+        # ========== AudioPlayback Test Cases (7 configs) ==========
+
+        # Playback Test 1: Config1 (16KHz, 16-bit, 2ch)
+        - $PWD/suites/Multimedia/Audio/AudioPlayback/run.sh --clip-name "Config1" --res-suffix "Config1" --audio-clips-path /home/AudioClips/ --no-extract-assets || true


In both scripts you do:
--clip-name/--config-name → sets USE_DISCOVERY=true
later --formats/--durations → currently sets USE_DISCOVERY=false
And your YAML currently passes --clip-name/--config-name before --formats/--durations, so the later legacy args can override discovery mode.

Fixed. Moved default value assignment (FORMATS/DURATIONS) to after the conflict check. Now defaults are only set when in legacy mode, preventing false positive conflicts in discovery mode.

smuppand · 2026-01-14T02:58:51Z

Runner/suites/Multimedia/Audio/AudioPlayback/run.sh

+    if ! validate_clip_file "$clip_path"; then
+      log_skip "[$case_name] SKIP: Invalid clip file: $clip_path"
+      echo "$case_name SKIP (invalid file)" >> "$LOGDIR/summary.txt"
+      skip=$(expr $skip + 1)


Old bug in the code. Please fix it. Make LOGDIR absolute to the test directory.

If the script is invoked from Runner/ (as your premerge plan does), mkdir happens under Runner/results/..., but later file writes happen after cd and expect results/... under the suite directory. That can lead to missing directories and failed redirects.

Fixed.
LOGDIR now uses absolute path $SCRIPT_DIR/results/${TESTNAME}.

smuppand · 2026-01-14T03:00:52Z

Runner/suites/Multimedia/Audio/AudioPlayback/run.sh

+    # Validate clip file
+    if ! validate_clip_file "$clip_path"; then
+      log_skip "[$case_name] SKIP: Invalid clip file: $clip_path"
+      echo "$case_name SKIP (invalid file)" >> "$LOGDIR/summary.txt"


anchor .res paths to SCRIPT_DIR for early failures + keep exit-code behavior consistent.

Fixed.
RES_FILE now uses absolute path $SCRIPT_DIR/${TESTNAME}.res. Result files created in correct location with consistent exit codes.

smuppand · 2026-01-15T14:41:00Z

Runner/utils/audio_common.sh

+  # Extract rate, bits, and channels in one sed call
+  # Pattern matches exact 4-field structure from end: _RATE_DURATIONs_BITS_CHANNELS.wav
+  # Anchored to .wav extension to ensure we're matching the correct fields
+  metadata="$(printf '%s' "$filename" | sed -n 's/.*_\([0-9.]\+KHz\)_\([0-9]\+s\)_\([0-9]\+b\)_\([0-9]\+ch\)\.wav$/\1 \3 \4/p')"


the sed pattern contains literal ... ([0-9....Hz) which will never match real filenames.
Fix it to a real, portable pattern (also removes GNU +)

There are several sed patterns using + (GNU extension). Since the repo repeatedly demands POSIX/ShellCheck clean, this will bite across Yocto/busybox variants.
Replace things like:
([[:alnum:]]+) → ([[:alnum:]][[:alnum:]_])
[0-9]+ → [0-9][0-9]
[0-9.]+ → [0-9][0-9.]* (or [0-9.][0-9.]*)

Fixed. All sed patterns in audio_common.sh now use POSIX-compliant syntax:

Changed [0-9]\+ to [0-9][0-9]* (one digit followed by zero or more)

Changed [0-9.]\+ to [0-9.][0-9.]* for decimal numbers

Changed [[:alnum:]_]\+ to [[:alnum:]_][[:alnum:]_]*

smuppand · 2026-01-15T14:44:46Z

Runner/suites/Multimedia/Audio/AudioRecord/run.sh

-RES_FILE="./${TESTNAME}.res"
-LOGDIR="results/${TESTNAME}"
+# Use absolute paths for LOGDIR to work from any directory
+LOGDIR="$SCRIPT_DIR/results/${TESTNAME}"


RES_SUFFIX is used, but logs will overwrite across multiple runs
You suffix the result file, but LOGDIR is still constant (logs_AudioPlayback, logs_AudioRecord).
In the premerge plan you run multiple configs back-to-back → logs collide/overwrite in both run.sh files

Fixed. LOGDIR now applies the same suffix as RES_FILE to create unique log directories per invocation:

Applied to both AudioPlayback and AudioRecord. The script logs "Using unique log directory: ..." when a suffix is provided.

This matches the RES_FILE behavior and prevents log collisions in CI/LAVA workflows with back-to-back runs.

srikanth007m · 2026-01-16T13:25:57Z

Runner/suites/Multimedia/Audio/AudioPlayback/AudioPlayback.yaml

-    - ./run.sh --backend "${AUDIO_BACKEND}" --sink "${SINK_CHOICE}" --formats "${FORMATS}" --durations "${DURATIONS}" --loops "${LOOPS}" --timeout "${TIMEOUT}" --strict "${STRICT}" --audio-clips-path "${AUDIO_CLIPS_BASE_DIR}" --ssid "${SSID}" --password "${PASSWORD}" || true
-    - $REPO_PATH/Runner/utils/send-to-lava.sh AudioPlayback.res || true
+    - ./run.sh --backend "${AUDIO_BACKEND}" --sink "${SINK_CHOICE}" --clip-name "${CLIP_NAMES}" --clip-filter "${CLIP_FILTER}" --formats "${FORMATS}" --durations "${DURATIONS}" --loops "${LOOPS}" --timeout "${TIMEOUT}" --strict "${STRICT}" --audio-clips-path "${AUDIO_CLIPS_BASE_DIR}" --res-suffix "${RES_SUFFIX}" --ssid "${SSID}" --password "${PASSWORD}" || true
+    - $REPO_PATH/Runner/utils/send-to-lava.sh AudioPlayback.res || true


But when RES_SUFFIX is set, your script writes:
AudioPlayback_Config1.res (etc), not AudioPlayback.res.
So LAVA will upload the wrong / stale / missing .res whenever suffix is used. update YAML to send ${TESTNAME}_${RES_SUFFIX}.res when RES_SUFFIX is set.
Do the same check for AudioRecord.yaml (it currently also sends AudioRecord.res unconditionally).

Fixed.
YAML patterns now use POSIX parameter expansion to handle both suffixed and non-suffixed cases correctly. Applied to both AudioPlayback.yaml and AudioRecord.yaml.

srikanth007m · 2026-01-16T13:30:35Z

Runner/suites/Multimedia/Audio/AudioRecord/run.sh

    log_fail "Overlay audio environment setup failed"
-    echo "$TESTNAME FAIL" > "$RES_FILE"
+    # Use absolute path for result file (early failure before RES_FILE is set)
+    echo "$TESTNAME FAIL" > "$SCRIPT_DIR/${TESTNAME}.res"


You fixed suffixing after CLI parse, but both AudioPlayback/run.sh and AudioRecord/run.sh still do That happens before parsing --res-suffix. If overlay setup fails in parallel CI runs, you’re back to collisions on AudioPlayback.res / AudioRecord.res.

do a minimal “pre-parse” of just --res-suffix before calling setup_overlay_audio_environment, so even early failures write to the suffixed res.

Fixed.
Added pre-parsing of --res-suffix before setup_overlay_audio_environment() to ensure unique result files even on early failures. Applied to both AudioPlayback and AudioRecord.

srikanth007m · 2026-01-16T13:36:25Z

Runner/suites/Multimedia/Audio/AudioPlayback/run.sh

+    # Aggregate result for this clip
+    if [ "$ok_runs" -ge 1 ]; then
+      pass=$(expr $pass + 1)
+      echo "$case_name PASS" >> "$LOGDIR/summary.txt"


summary.txt is appended but not reset
You append per-test results

echo "$case_name PASS" >> "$LOGDIR/summary.txt"
But I didn’t see : > "$LOGDIR/summary.txt" after creating LOGDIR. That will accumulate results across repeated invocations in the same workspace (classic CI flake source).
truncate it once after mkdir -p "$LOGDIR".

Fixed.
Added truncation of summary.txt immediately after LOGDIR creation to prevent accumulation across repeated invocations. Applied to both AudioPlayback and AudioRecord.
This ensures each test run starts with a clean summary.txt file.

smuppand

minor nit changes.

smuppand · 2026-01-20T16:17:33Z

Runner/suites/Multimedia/Audio/AudioRecord/AudioRecord.yaml

+  CONFIG_NAMES: "record_config1"  # Test specific configs (e.g., "record_config1 record_config2"), default: record_config1
+  CONFIG_FILTER: ""  # Filter configs by pattern (e.g., "48KHz" or "2ch"), default: unset
+  DURATIONS: "short"  # Recording durations: short, medium, long, default: short
  RECORD_SECONDS: 5  # Number of seconds to record (numeric or mapped), default: 5


RECORD_SECONDS default to "5s" (or ensure script robustly accepts plain 5 everywhere).

Fixed.
Changed the YAML default from 5 to "5s" to match the expected format. Now both the YAML and script use the same format with unit suffix.

smuppand · 2026-01-20T16:19:09Z

Runner/suites/Multimedia/Audio/AudioRecord/run.sh

+    else
+      echo "$TESTNAME FAIL" > "$SCRIPT_DIR/${TESTNAME}.res"
+    fi
    exit 1


Prefer always exit 0 after writing FAIL to .res

Fixed.
Changed the early failure exit code from exit 1 to exit 0 in both AudioPlayback and AudioRecord scripts.

Expanded audio testing from 2 to 10 test cases in the pre-merge CI pipeline to improve validation coverage across different audio formats and configurations. Changes: - AudioRecord: Added support for 10 recording configurations - AudioPlayback: Added support for 20 playback configurations - meta-ar-ci-premerge.yaml: Updated to run 7 playback + 3 record tests - Added --res-suffix parameter for unique result files and log directories - Fixed LOGDIR collision across multiple test runs in CI/LAVA environments - Fixed summary.txt accumulation bug across repeated invocations - Fixed early failure handling to ensure unique result files in parallel CI - Fixed YAML to send correct suffixed result files to LAVA - Updated documentation with CI/LAVA workflow examples AudioRecord enhancements: * Implemented config discovery mode with 10 predefined test configurations * Added --config-name and --config-filter CLI options for flexible test selection * Added --res-suffix option to generate unique result files and log directories (e.g., AudioRecord_Config1.res and results/AudioRecord_Config1/) * Fixed LOGDIR to apply suffix, preventing log overwriting in back-to-back runs * Fixed summary.txt truncation after LOGDIR creation to prevent accumulation * Added pre-parsing of --res-suffix for early failure handling before CLI parsing * Updated documentation with configuration table and usage examples * Added CI/LAVA workflow examples with validated output * Modified YAML to support new config parameters (defaults to record_config1) * Updated YAML with RES_SUFFIX parameter for parallel test execution AudioPlayback enhancements: * Implemented clip discovery mode with 20 predefined test configurations * Added --clip-name and --clip-filter CLI options for flexible test selection * Added --res-suffix option to generate unique result files and log directories (e.g., AudioPlayback_Config1.res and results/AudioPlayback_Config1/) * Fixed LOGDIR to apply suffix, preventing log overwriting in back-to-back runs * Fixed summary.txt truncation after LOGDIR creation to prevent accumulation * Added pre-parsing of --res-suffix for early failure handling before CLI parsing * Updated documentation with configuration table and usage examples * Added CI/LAVA workflow examples with validated output * Modified YAML to support new clip parameters (defaults to Config1) * Updated YAML with RES_SUFFIX parameter for parallel test execution Pre-merge CI updates: * 7 playback tests: Config1, Config7, Config13, Config15, Config18, Config20, Config5 * 3 record tests: record_config1, record_config7, record_config10 * Uses pre-staged clips at /home/AudioClips/ for faster execution * 10-second recording duration for efficient CI runtime * Unique result files and log directories prevent overwriting in parallel execution * Each test run creates isolated logs (e.g., results/AudioPlayback_Config1/) * Early failures now write to correct suffixed result files * LAVA correctly uploads suffixed result files for each test Test coverage now includes: - Sample rates: 8KHz to 384KHz - Bit depths: 8-bit to 32-bit - Channel configs: Mono, Stereo Signed-off-by: Teja Swaroop Moida <tmoida@qti.qualcomm.com>

smuppand

LGTM

smuppand requested review from abbajaj806 and smuppand January 2, 2026 17:58

smuppand requested changes Jan 7, 2026

View reviewed changes

tmoida force-pushed the patch-1 branch 2 times, most recently from 6fbded5 to f691a38 Compare January 12, 2026 10:47

smuppand requested changes Jan 13, 2026

View reviewed changes

tmoida force-pushed the patch-1 branch from f691a38 to 828a5c3 Compare January 13, 2026 12:48

smuppand requested changes Jan 14, 2026

View reviewed changes

tmoida force-pushed the patch-1 branch from 828a5c3 to 853f394 Compare January 14, 2026 09:22

smuppand requested changes Jan 15, 2026

View reviewed changes

tmoida force-pushed the patch-1 branch from 853f394 to 34cd43e Compare January 16, 2026 11:07

tmoida requested a review from smuppand January 16, 2026 11:13

srikanth007m suggested changes Jan 16, 2026

View reviewed changes

tmoida force-pushed the patch-1 branch from 34cd43e to f6dc26c Compare January 19, 2026 10:49

smuppand requested changes Jan 20, 2026

View reviewed changes

tmoida force-pushed the patch-1 branch from f6dc26c to 079726a Compare January 21, 2026 11:15

smuppand approved these changes Jan 21, 2026

View reviewed changes

smuppand merged commit ec0bc09 into qualcomm-linux:main Jan 21, 2026
8 checks passed

vnarapar mentioned this pull request Jan 22, 2026

Add changes to enable audio playback test along with its dependencies qualcomm-linux/lava-test-plans#6

Merged

Audio: Increase pre-merge test coverage to 10 test cases #243

Audio: Increase pre-merge test coverage to 10 test cases #243

Uh oh!

Conversation

tmoida commented Jan 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tmoida commented Jan 12, 2026

PR Response - Review Comments Addressed

Changes Made

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tmoida commented Jan 13, 2026

Uh oh!

smuppand commented Jan 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!