Prevent assignment to None for non-Optional class variables #20054
+8
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Python 3.5 has been dead for a long time
hauntsaninja
force-pushed
the
strictnone
branch
from
02a5c1b to
e2c7df8
Compare
This comment has been minimized.
This comment has been minimized.
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Jan 17, 2026
This is a subset of python#20054 Just makes that PR less likely to develop merge conflicts
Collaborator
Author
|
Merging most of the test changes in #20611 |
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Jan 17, 2026
This is a subset of python#20054 Just makes that PR less likely to develop merge conflicts
hauntsaninja
added a commit
that referenced
this pull request
Jan 18, 2026
This is a subset of #20054 to make that PR less likely to merge conflict
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: tornado (https://github.com/tornadoweb/tornado)
+ tornado/util.py:240: error: Incompatible types in assignment (expression has type "None", variable has type "dict[str, Any]") [assignment]
+ tornado/httputil.py:484: error: Incompatible types in assignment (expression has type "None", variable has type "str") [assignment]
+ tornado/httputil.py:485: error: Incompatible types in assignment (expression has type "None", variable has type "str") [assignment]
+ tornado/httputil.py:488: error: Incompatible types in assignment (expression has type "None", variable has type "Future[None]") [assignment]
+ tornado/netutil.py:519: error: Incompatible types in assignment (expression has type "None", variable has type "int") [assignment]
+ tornado/iostream.py:1327: error: Incompatible types in assignment (expression has type "None", variable has type "SSLSocket") [assignment]
+ tornado/httpclient.py:179: error: Incompatible types in assignment (expression has type "None", variable has type "dict[IOLoop, AsyncHTTPClient]") [assignment]
+ tornado/httpclient.py:342: error: Incompatible types in assignment (expression has type "None", variable has type "dict[str, str] | HTTPHeaders") [assignment]
+ tornado/httpclient.py:629: error: Incompatible types in assignment (expression has type "None", variable has type "HTTPRequest") [assignment]
+ tornado/web.py:208: error: Incompatible types in assignment (expression has type "None", variable has type "list[OutputTransform]") [assignment]
+ tornado/web.py:209: error: Incompatible types in assignment (expression has type "None", variable has type "list[str]") [assignment]
+ tornado/web.py:210: error: Incompatible types in assignment (expression has type "None", variable has type "dict[str, str]") [assignment]
+ tornado/websocket.py:837: error: Incompatible types in assignment (expression has type "None", variable has type "IOStream") [assignment]
+ tornado/websocket.py:1399: error: Incompatible types in assignment (expression has type "None", variable has type "WebSocketProtocol") [assignment]
+ tornado/test/web_test.py:224: error: Incompatible types in assignment (expression has type "None", variable has type "Future[Any]") [assignment]
dd-trace-py (https://github.com/DataDog/dd-trace-py)
+ ddtrace/internal/remoteconfig/_pubsub.py:85: error: Incompatible types in assignment (expression has type "None", variable has type "PublisherSubscriberConnector") [assignment]
+ ddtrace/internal/remoteconfig/_pubsub.py:86: error: Incompatible types in assignment (expression has type "None", variable has type "RemoteConfigPublisherBase") [assignment]
+ ddtrace/internal/remoteconfig/_pubsub.py:87: error: Incompatible types in assignment (expression has type "None", variable has type "RemoteConfigSubscriber") [assignment]
+ ddtrace/llmobs/_llmobs.py:229: error: Incompatible types in assignment (expression has type "None", variable has type "LLMObs") [assignment]
alerta (https://github.com/alerta/alerta)
+ alerta/models/alarms/__init__.py:22: error: Incompatible types in assignment (expression has type "None", variable has type "str") [assignment]
+ alerta/models/alarms/__init__.py:23: error: Incompatible types in assignment (expression has type "None", variable has type "str") [assignment]
+ alerta/models/alarms/__init__.py:24: error: Incompatible types in assignment (expression has type "None", variable has type "str") [assignment]
+ alerta/models/alarms/__init__.py:25: error: Incompatible types in assignment (expression has type "None", variable has type "str") [assignment]
stone (https://github.com/dropbox/stone)
+ stone/backend.py:92: error: Incompatible types in assignment (expression has type "None", variable has type "ArgumentParser") [assignment]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.5 has been dead for a long time.