Skip to content

feat: support constant folding in ExpressionChecker.visit_typeddict_index_expr [1/1] #19976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BobTheBuidler wants to merge 7 commits into
base: master
Choose a base branch
from
+2 −2
Open

feat: support constant folding in ExpressionChecker.visit_typeddict_index_expr [1/1] #19976

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe6412d
[mypyc] feat: support constant folding in `ExpressionChecker.visit_ty…
BobTheBuidler Oct 2, 2025
b75337c
Merge branch 'master' into constant-fold-typeddict-index
BobTheBuidler Oct 2, 2025
bae33b3
Merge branch 'master' into constant-fold-typeddict-index
BobTheBuidler Oct 4, 2025
e498c67
Merge branch 'master' into constant-fold-typeddict-index
BobTheBuidler Oct 6, 2025
6b78eec
Merge branch 'master' into constant-fold-typeddict-index
BobTheBuidler Oct 14, 2025
8d4d2f8
Merge branch 'master' into constant-fold-typeddict-index
BobTheBuidler Jan 6, 2026
c56666e
Merge branch 'master' into constant-fold-typeddict-index
BobTheBuidler Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mypy/checkexpr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4651,8 +4651,8 @@ def union_tuple_fallback_item(self, left_type: TupleType) -> Type:
def visit_typeddict_index_expr(
self, td_type: TypedDictType, index: Expression, setitem: bool = False
) -> tuple[Type, set[str]]:
if isinstance(index, StrExpr):
key_names = [index.value]
if isinstance(folded_index := constant_fold_expr(index, "unused"), str):
Copy link
Collaborator

@hauntsaninja hauntsaninja Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make cur_mod_id an invalid identifier?

Suggested change
if isinstance(folded_index := constant_fold_expr(index, "unused"), str):
if isinstance(folded_index := constant_fold_expr(index, "--dummy.name--"), str):

key_names = [folded_index]
else:
typ = get_proper_type(self.accept(index))
if isinstance(typ, UnionType):
Expand Down