Fix race condition when closing jitdump file in perf JIT trampoline #143965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perf JIT trampoline code writes to a shared FILE* from multiple threads
(perf_map_jit_write_entry can be called concurrently when generating JIT code),
but it does so without holding the map_lock.
During interpreter shutdown, perf_map_jit_fini() closes the file while holding
the lock, but sets perf_map to NULL only after releasing the lock.
This opens a small race window where a concurrent write could:
(likely a crash or corrupted jitdump file).
Although the JIT perf support is experimental and the race is rare,
it is a real thread-safety bug.
This change fixes it by:
waiting for the lock).
for consistency.
No functional changes in the single-threaded case, and no regression in
jitdump file format or perf compatibility.
Fixes a potential use-after-close (CWE-910).