GH-143941: Move WASI-related files to Platforms/WASI #143942
Conversation
Along the way, leave a deprecated Tools/wasm/wasi/__main__.py behind for backwards-compatibility.
brettcannon
requested review from
AA-Turner,
AlexWaygood,
emmatyping,
ezio-melotti,
freakboy3742,
hugovk and
savannahostrowski
as code owners
zware
left a comment
zware
left a comment
There was a problem hiding this comment.
LGTM with a CODEOWNERS nit and a future archaeology suggestion. Note that I didn't really actually review any changes in __main__.py since it's completely recreated.
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
| runpy.run_path(checkout / "Platforms" / "WASI", run_name="__main__") |
There was a problem hiding this comment.
For nicer history, it might be better to just do the full rename in this PR and follow it up with adding the new redirect here.
I'll suppress my rant about only allowing squash merges :)
There was a problem hiding this comment.
But if I just did a rename it would break the buildbots and leave the repo after this commit in a somewhat broken state for anyone else building.
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
Can you please update:
cpython/Tools/build/compute-changes.py
Line 53 in bb25f72
| Move WASI-related files to Platforms/WASI. Along the way, leave a deprecated | ||
| Tools/wasm/wasi/__main__.py behind for backwards-compatibility. |
There was a problem hiding this comment.
| Move WASI-related files to Platforms/WASI. Along the way, leave a deprecated | |
| Tools/wasm/wasi/__main__.py behind for backwards-compatibility. | |
| Move WASI-related files to :file:`Platforms/WASI`. Along the way, leave a deprecated | |
| :file:`Tools/wasm/wasi/__main__.py` behind for backwards-compatibility. |
|
|
||
| LOCAL_SETUP = CHECKOUT / "Modules" / "Setup.local" | ||
| LOCAL_SETUP_MARKER = ( | ||
| b"# Generated by Tools/wasm/wasi .\n" |
There was a problem hiding this comment.
Should this not be updated?
4 participants
Along the way, leave a deprecated Tools/wasm/wasi/main.py behind for backwards-compatibility.
Platforms/WASI#143941