Skip to content

gh-143935: Email preserve parens when folding comments #143936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sethmlarson wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-143935: Email preserve parens when folding comments #143936

sethmlarson wants to merge 5 commits into from

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Jan 16, 2026 •
edited by bedevere-app bot
Loading

@sethmlarson sethmlarson requested a review from bitdancer January 16, 2026 20:41
@sethmlarson sethmlarson requested a review from a team as a code owner January 16, 2026 20:41
@bedevere-app bedevere-app bot mentioned this pull request Jan 16, 2026
Open
@beledouxdenis @sethmlarson
email: use same strategy as quoted-string to fold comments
6142a37 
- No forced space to indent,
- use almost the same code as the `bare-quoted-string`
block above, handle nested comments and escaped parenthesis
in addition
@beledouxdenis @sethmlarson
email: do not fold WhiteSpaceTerminal not starting with a WSP
7f05244 
e.g. with a 40 characters length policy, the below
`((loremipsum)(loremipsum)(loremipsum)(loremipsum))<spy@example.org>`

should not be folded to
`((loremipsum)(loremipsum)(loremipsum)\n(loremipsum))<spy@example.org>`

but should rather stay
`((loremipsum)(loremipsum)(loremipsum)(loremipsum))<spy@example.org>`

to prevent to add a new line not starting with a space / with no
indentation
@beledouxdenis @sethmlarson
email: test case for blank between nested comment
db74b26 
To test a whitespace between two nested comments leads to a
new line with one space indentation on folding
@beledouxdenis @sethmlarson
email: add a blurb
8ad0fdb
@sethmlarson sethmlarson force-pushed the email-preserve-parens-when-folding-comments branch from 3a9b2c7 to 8ad0fdb Compare January 16, 2026 20:45
@sethmlarson sethmlarson added type-security A security issue stdlib Standard Library Python modules in the Lib/ directory topic-email labels Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer Awaiting requested review from bitdancer

Assignees

No one assigned

Labels

awaiting review stdlib Standard Library Python modules in the Lib/ directory topic-email type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sethmlarson @beledouxdenis