gh-143916: Reject control characters in wsgiref.headers.Headers #143917
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
added
type-security
webknjaz
reviewed
Jan 16, 2026
Comment on lines
+509
to
+513
| self.assertRaises(ValueError, headers.__setitem__, f"key{c0}", "val") | ||
| self.assertRaises(ValueError, headers.__setitem__, "key", f"val{c0}") | ||
| self.assertRaises(ValueError, headers.add_header, f"key{c0}", "val", param="param") | ||
| self.assertRaises(ValueError, headers.add_header, "key", f"val{c0}", param="param") | ||
| self.assertRaises(ValueError, headers.add_header, "key", "val", param=f"param{c0}") |
Member
There was a problem hiding this comment.
Consider marking params as subtests for better test report.
Suggested change
| self.assertRaises(ValueError, headers.__setitem__, f"key{c0}", "val") | |
| self.assertRaises(ValueError, headers.__setitem__, "key", f"val{c0}") | |
| self.assertRaises(ValueError, headers.add_header, f"key{c0}", "val", param="param") | |
| self.assertRaises(ValueError, headers.add_header, "key", f"val{c0}", param="param") | |
| self.assertRaises(ValueError, headers.add_header, "key", "val", param=f"param{c0}") | |
| with self.subTest(control_character=hex(ord(c0[0]))): | |
| self.assertRaises(ValueError, headers.__setitem__, f"key{c0}", "val") | |
| self.assertRaises(ValueError, headers.__setitem__, "key", f"val{c0}") | |
| self.assertRaises(ValueError, headers.add_header, f"key{c0}", "val", param="param") | |
| self.assertRaises(ValueError, headers.add_header, "key", f"val{c0}", param="param") | |
| self.assertRaises(ValueError, headers.add_header, "key", "val", param=f"param{c0}") |
Contributor
Author
There was a problem hiding this comment.
Are you okay if I don't adopt subTest() here? I ask because I have many other PRs out that I'd need to modify, too.
Member
There was a problem hiding this comment.
Sure, I won't insist. It's just that I usually try to make logical tests obvious. It's typically easier in newly added lines rather than when refactoring existing tests.
Member
There was a problem hiding this comment.
It is not really needed. We will see the failing line. We do not extensively use subTest as well, only when it really is needed (it adds indentation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.