Skip to content

Conversation

@google-labs-jules
Copy link

πŸ’‘ What:
Replaced manual byte-by-byte copy loops in ShareableMap.defragment and ShareableArray.defragment with Uint8Array.prototype.set using subarray views.
Fixed a bug in ShareableArray.defragment where DATA_OBJECT_OFFSET was incorrectly added twice to the currentDataStart pointer, causing gaps in the defragmented array.

🎯 Why:
The manual copy loop was slow (~62ms for 10MB/256B blocks vs ~6ms with set).
The offset bug in ShareableArray wasted 8 bytes of memory per item during defragmentation.

πŸ“Š Impact:

  • ~10x speedup for the memory copy phase during defragmentation.
  • Reduced memory usage in ShareableArray after defragmentation by eliminating unnecessary gaps.

πŸ”¬ Measurement:
Verified with a reproduction test that confirmed the offset bug fix (memory usage dropped from 872 to 840 bytes in test scenario).
Verified optimization with a standalone benchmark (not included in PR).
Verified full test suite passes.


PR created automatically by Jules for task 5877455073732309065 started by @pverscha

@google-labs-jules
Copy link
Author

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant