-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add kubectl feature #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
be9964d to
1afe8d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new kubectl devcontainer feature that installs kubectl and related Kubernetes tools (kubectx, kubens, k9s, helm, kustomize, kubeconform, kube-score, and fzf). It also updates dependencies and adds GitHub API token support for handling rate limits when fetching version information.
Changes:
- Adds kubectl feature with support for installing multiple Kubernetes-related tools
- Implements GitHub API token authentication to mitigate API rate limiting
- Updates Go dependencies and consolidates build task definitions
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| features/src/kubectl/devcontainer-feature.json | Defines feature metadata and configuration options for kubectl and related tools |
| features/src/kubectl/install.sh | Shell script entry point for installing kubectl feature |
| features/src/kubectl/installer.go | Go implementation for downloading and installing kubectl tools |
| features/test/kubectl/test-images.json | Test container images for kubectl feature |
| features/test/kubectl/scenarios.json | Test scenarios configuration |
| features/test/kubectl/install.sh | Test script for basic installation scenario |
| features/test/kubectl/full.sh | Test script for full installation with all tools |
| installer/github.go | Adds GitHub API token support via DEV_FEATURE_TOKEN_GITHUB_API environment variable |
| override-all.env | Adds override environment variables for kubectl download URLs |
| build/build.go | Adds kubectl build tasks and consolidates task definitions |
| go.mod / go.sum | Updates Go version and dependencies |
| README.md | Adds documentation for API tokens and development workflows |
| .github/workflows/ci.yml | Adds kubectl to CI test matrix |
39e5067 to
e18efe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
features/src/kubectl/installer.go:1
- The variable names semVerRegex and threeDigitRegex are inconsistent. The first uses 'Regex' while the second uses 'Regex'. However, 'threeDigitRegex' is somewhat misleading as it actually matches 2-3 digits (2 or 3 numeric parts), not specifically three digits. Consider renaming to 'twoOrThreeDigitRegex' or 'standardVersionRegex' for clarity.
package main
e18efe8 to
cc911a6
Compare
No description provided.