Skip to content

Strip suffix when comparing versions #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mbeccati wants to merge 1 commit into
base: 1.3.x
Choose a base branch
from
Open

Strip suffix when comparing versions #487

mbeccati wants to merge 1 commit into from
+2 −2

Conversation

@mbeccati
Copy link
Contributor

@mbeccati mbeccati commented Jan 21, 2026 

1) Php\PieUnitTest\Platform\TargetPhp\PhpBinaryPathTest::testVersionFromCurrentProcess
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'8.5.3-dev'
+'8.5.3'

:-)

asgrim
asgrim reviewed Jan 21, 2026
View reviewed changes
@mbeccati mbeccati force-pushed the fix-php-version-check branch from 1797e51 to 4a95fae Compare January 21, 2026 09:29
@mbeccati mbeccati force-pushed the fix-php-version-check branch from 4a95fae to 7df9e3e Compare January 21, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asgrim asgrim asgrim left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mbeccati @asgrim