fix some missing optional <-> required cases + new optional query param #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
ahl
approved these changes
Jan 24, 2026
Comment on lines
+136
to
+137
| // New optional parameters are forward-incompatible because new clients | ||
| // might send the parameter to old servers that don't understand it. |
Collaborator
There was a problem hiding this comment.
I had thought that old servers would just ignore those parameters... which is true, but probably means that new clients aren't getting the semantics they expect.
src/compare.rs
Outdated
| new_body_or_ref.resolve(new_request_body.context())?; | ||
|
|
||
| // Check if the required field changed. | ||
| if !old_body.required && new_body.required { |
Collaborator
There was a problem hiding this comment.
I think if I had it to do over, I would have destructured old_body and new_body to force us to consider each property explicitly (which would have made it harder to miss this case).
Contributor
Author
There was a problem hiding this comment.
Done -- also reported description and extensions changes as trivial ones.
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/fix-some-missing-optional-required-cases-new-optional-query-param
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following cases: