Skip to content

Fix payload CRD/FetaureGate ordering #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jan 26, 2026
+3 −1
Merged

Fix payload CRD/FetaureGate ordering #2667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,15 +114,17 @@ update-scripts: update-compatibility update-openapi update-deepcopy update-proto
# Update codegen runs all generators in the order they are defined in the root.go file.
# The per group generators are:[compatibility, deepcopy, swagger-docs, empty-partial-schema, schema-patch, crd-manifest-merge]
# The multi group generators are:[openapi]
# The payload generation must come after these generators have run so they are included here as well, rather than in update-non-codegen.
.PHONY: update-codegen
update-codegen:
hack/update-codegen.sh
make update-payload-crds update-payload-featuregates

# Update non-codegen runs all generators that are not part of the codegen utility, or
# are part of it, but are not run by default when invoking codegen without a specific generator.
# E.g. the payload feature gates which is not part of the generator style, but is still a subcommand.
.PHONY: update-non-codegen
update-non-codegen: update-protobuf tests-vendor update-prerelease-lifecycle-gen update-payload-crds update-payload-featuregates
update-non-codegen: update-protobuf tests-vendor update-prerelease-lifecycle-gen
Copy link

@coderabbitai coderabbitai bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Minor: trailing whitespace.

There's a trailing space at the end of line 127.

Proposed fix 
-.PHONY: update-non-codegen
-update-non-codegen: update-protobuf tests-vendor update-prerelease-lifecycle-gen 
+.PHONY: update-non-codegen
+update-non-codegen: update-protobuf tests-vendor update-prerelease-lifecycle-gen
🤖 Prompt for AI Agents 
In `@Makefile` at line 127, The Makefile line defining the update-non-codegen
target contains a trailing whitespace character at the end of the line; remove
the trailing space after "update-prerelease-lifecycle-gen" on the
update-non-codegen line so the target line reads without any trailing whitespace
(look for the target name "update-non-codegen" in the Makefile).


.PHONY: update-compatibility
update-compatibility:
Expand Down