-
Notifications
You must be signed in to change notification settings - Fork 596
Add delay to activation of IFP tallies. #3728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GuySten
wants to merge
11
commits into
openmc-dev:develop
Choose a base branch
from
GuySten:IFP-inactive
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+157
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
GuySten
commented
Jan 14, 2026
GuySten
commented
Jan 14, 2026
Contributor
|
Hi @GuySten, thanks for the effort! I will probably need some time to get back to it more in depth, but I really like what you did in terms of simplification and cleaning. Do you see any impact in terms of runtime performance? |
Contributor
Author
|
The motivation for the simplifications is just cleaner code. |
Contributor
Author
|
This PR is now ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, IFP tallies are scored in active batches but because they contain data from ifp_n_generations before they contain data from inactive batches (where the fission source distribution might not be converged).
Instead of making the user remember to increase the number of inactive batches when using IFP tallies this PR propose the elegant solution of activating the IFP tallies later (by ifp_n_generation).
This PR also further simplify the IFP implementation.
Checklist
I have followed the style guidelines for Python source files (if applicable)