Skip to content

Conversation

@GuySten
Copy link
Contributor

@GuySten GuySten commented Jan 14, 2026

Description

Currently, IFP tallies are scored in active batches but because they contain data from ifp_n_generations before they contain data from inactive batches (where the fission source distribution might not be converged).
Instead of making the user remember to increase the number of inactive batches when using IFP tallies this PR propose the elegant solution of activating the IFP tallies later (by ifp_n_generation).

This PR also further simplify the IFP implementation.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten marked this pull request as draft January 14, 2026 18:40
@JoffreyDorville
Copy link
Contributor

Hi @GuySten, thanks for the effort! I will probably need some time to get back to it more in depth, but I really like what you did in terms of simplification and cleaning. Do you see any impact in terms of runtime performance?

@GuySten
Copy link
Contributor Author

GuySten commented Jan 14, 2026

The motivation for the simplifications is just cleaner code.
I did not check performance difference.

@GuySten GuySten marked this pull request as ready for review January 15, 2026 04:12
@GuySten
Copy link
Contributor Author

GuySten commented Jan 16, 2026

This PR is now ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants