Skip to content

Conversation

@jack-berg
Copy link
Member

The opentelemetry-sdk-common module does not follow our packaging conventions. It has a decent amount of internal code in a package called io.opentelemetry.sdk.internal, which should be in io.opentelemetry.sdk.common.internal.

The problem with io.opentelemetry.sdk.internal is that we have another module opentelemetry-sdk, whose root package is io.opentelemetry.sdk. By coincidence, opentelemetry-sdk hasn't needed any internal code up to this point. But in discussion for PR#7991, I believe that's changing and opentelemetry-sdk will now need internal code. And we have a conflict if both opentelemetry-sdk-common and opentelemetry-sdk both publish to the io.opentelemetry.sdk.internal package.

opentelemetry-sdk-common should move its internal code to the proper package io.opentelemetry.sdk.common.internal to conform with the conventions of this repo.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (8e332fc) to head (5ff8db5).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8003      +/-   ##
============================================
- Coverage     90.15%   90.13%   -0.02%     
+ Complexity     7476     7475       -1     
============================================
  Files           834      834              
  Lines         22540    22540              
  Branches       2236     2236              
============================================
- Hits          20320    20317       -3     
- Misses         1515     1517       +2     
- Partials        705      706       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant