Move io.opentelemetry.sdk.internal to io.opentelemetry.sdk.common.internal #8003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
opentelemetry-sdk-commonmodule does not follow our packaging conventions. It has a decent amount of internal code in a package calledio.opentelemetry.sdk.internal, which should be inio.opentelemetry.sdk.common.internal.The problem with
io.opentelemetry.sdk.internalis that we have another moduleopentelemetry-sdk, whose root package isio.opentelemetry.sdk. By coincidence,opentelemetry-sdkhasn't needed any internal code up to this point. But in discussion for PR#7991, I believe that's changing andopentelemetry-sdkwill now need internal code. And we have a conflict if bothopentelemetry-sdk-commonandopentelemetry-sdkboth publish to theio.opentelemetry.sdk.internalpackage.opentelemetry-sdk-commonshould move its internal code to the proper packageio.opentelemetry.sdk.common.internalto conform with the conventions of this repo.